Only send 2 MiB of log data in diagnose report #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
read-limited-file-contents
branch
2 times, most recently
from
fc88817 to
24edfd5
Compare
Don't send too much log file data. We previously decided upon 2 MiB of data for the appsignal.log in the Ruby gem, so apply that in the Node.js integration too. I wrote the reading of this data in a sync way, with `Sync` functions from the `fs` module. I could not get it to work with promises and async without rewriting the entire script to be async, which seemed like a lot of work for this change. This sync approach is less safe I think, because we need to close the open file manually. To make it more safe I've added the file closing to the `finally` statement that triggers in the try-block regardless if an error occurs in the try-block. The finally-block is like an ensure-block in Ruby. Closes #413
tombruijn
force-pushed
the
read-limited-file-contents
branch
from
24edfd5 to
068e2fb
Compare
jeffkreeftmeijer
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't send too much log file data. We previously decided upon 2 MiB of
data for the appsignal.log in the Ruby gem, so apply that in the Node.js
integration too.
I wrote the reading of this data in a sync way, with
Syncfunctionsfrom the
fsmodule. I could not get it to work with promises and asyncwithout rewriting the entire script to be async, which seemed like a lot
of work for this change.
This sync approach is less safe I think, because we need to close the
open file manually. To make it more safe I've added the file closing to
the
finallystatement that triggers in the try-block regardless if anerror occurs in the try-block. The finally-block is like an ensure-block
in Ruby.
Closes #413