Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Next.js test #636

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Disable Next.js test #636

merged 2 commits into from
Mar 28, 2022

Conversation

unflxw
Copy link
Contributor

@unflxw unflxw commented Mar 28, 2022

Temporarily disable failing Next.js test

A test in the Next.js test suite is failing on Node 14 and Node 12.
Disable the test while the issue is being looked into.

Downgrade to NPM 8.5.3

In order to work around a bug in NPM 8.5.4 and above, where
lifecycle hooks are not executed for the workspace packages, use
NPM 8.5.3 for every Node version for now.

This is a redo of #629.

Relates to #632.

unflxw added 2 commits March 28, 2022 12:13
A test in the Next.js test suite is failing on Node 14 and Node 12.
Disable the test while the issue is being looked into.
In order to work around [a bug in NPM 8.5.4 and above][bug], where
lifecycle hooks are not executed for the workspace packages, use
NPM 8.5.3 for every Node version for now.

This is a redo of [#629][pr].

[bug]: npm/cli#4552
[pr]: #629
@unflxw unflxw requested a review from tombruijn March 28, 2022 11:45
@unflxw unflxw self-assigned this Mar 28, 2022
@unflxw unflxw added bug chore and removed bug labels Mar 28, 2022
@backlog-helper
Copy link

backlog-helper bot commented Mar 28, 2022

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

@unflxw unflxw changed the title Disable next js test Disable Next.js test Mar 28, 2022
@unflxw unflxw merged commit f3eaf18 into main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants