Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Probes.stop behavior #815

Closed
2 tasks done
tombruijn opened this issue Jan 27, 2022 · 0 comments · Fixed by #1069
Closed
2 tasks done

Add Probes.stop behavior #815

tombruijn opened this issue Jan 27, 2022 · 0 comments · Fixed by #1069
Assignees
@tombruijn
Labels
enhancement

Comments

@tombruijn
Copy link
Member

tombruijn commented Jan 27, 2022 •
edited
Loading

As agreed upon in https://github.com/appsignal/integration-guide/pull/124, add a function to manually stop the minutely probes.

This may help with issue appsignal/appsignal-nodejs#418

To do

  • Implement a public Minutely.stop function.
  • Call Minutely.stop in Appsignal.stop
@tombruijn tombruijn self-assigned this Apr 26, 2024
tombruijn added a commit that referenced this issue Apr 26, 2024
@tombruijn
Stop minutely probes thread on Appsignal.stop
5f97aa2 
Make sure the minutely probes thread is stopped when calling
`Appsignal.stop`. This makes sure nothing of the AppSignal gem is
running after you call stop.

This only affects apps that call stop manually (like in test suites),
because the thread is also stopped when the Ruby process stops.

Closes #815
@tombruijn tombruijn mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop minutely probes thread on Appsignal.stop appsignal/appsignal-ruby
1 participant
@tombruijn