Support nested webmachine apps #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the webmachine tests don't test if it sets the params, now it does. Also clean up some other spec stuff that's not needed.
Use a Webmachine resource to test the instrumentation. Use that to set a custom action name and test that it doesn't get overwritten by the instrumentation.
Apply the same logic as we have in the AbstractMiddleware for webmachine apps. When a parent transaction is active, use that and don't create a new one. More importantly, don't close the active transaction. The webmachine instrumentation can't use the AbstractMiddleware, or any middleware, as this discouraged by the webmachine project. In practice I don't see this happening, but if someone happens to add an AppSignal EventHandler to the middleware stack in `config.ru`, we now support it. Part of #329
tombruijn
force-pushed
the
webmachine-update
branch
from
e751f35 to
243d20a
Compare
luismiramirez
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test webmachine instrumentation to set params
I noticed the webmachine tests don't test if it sets the params, now it does.
Also clean up some other spec stuff that's not needed.
Test webmachine custom action names
Use a Webmachine resource to test the instrumentation. Use that to set a custom action name and test that it doesn't get overwritten by the instrumentation.
Support nested webmachine apps
Apply the same logic as we have in the AbstractMiddleware for webmachine apps. When a parent transaction is active, use that and don't create a new one. More importantly, don't close the active transaction.
The webmachine instrumentation can't use the AbstractMiddleware, or any middleware, as this discouraged by the webmachine project. In practice I don't see this happening, but if someone happens to add an AppSignal EventHandler to the middleware stack in
config.ru, we now support it.Part of #329