Restore default (ignore) Rust SIGPIPE behavior #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `reset_sigpipe` and other code that handles `SIGPIPE` in any way, such as ignoring it or forwarding it to the child process. This restores the default behaviour of the Rust standard library, which is to always ignore the signal. This behaviour will be inherited by the child process. See #12 for context.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
reset_sigpipeand other code that handlesSIGPIPEin any way, such as ignoring it or forwarding it to the child process.This restores the default behaviour of the Rust standard library, which is to always ignore the signal. This behaviour will be inherited by the child process.
See #12 for context.