Make /proc/diskstats compatible with Kernel 4.18+ #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernel 4.18+ appends four more fields for discard tracking putting the total at 18: 15 - discards completed successfully 16 - discards merged 17 - sectors discarded 18 - time spent discarding This commit makes the readout compatible with these new fields.
thijsc
approved these changes
May 8, 2019
tombruijn
approved these changes
May 20, 2019
tombruijn
added a commit
to appsignal/appsignal-ruby
that referenced
this pull request
Jul 22, 2019
- Fix container CPU runtime metrics. See appsignal/probes-rs#38 for more information. - Improve host metrics calculations accuracy for counter metrics. See appsignal/probes-rs#40 for more information. - Support Kernel 4.18+ format of /proc/diskstats file parsing. See appsignal/probes-rs#39 for more information.
tombruijn
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jul 22, 2019
- Fix container CPU runtime metrics. See appsignal/probes-rs#38 for more information. - Improve host metrics calculations accuracy for counter metrics. See appsignal/probes-rs#40 for more information. - Support Kernel 4.18+ format of /proc/diskstats file parsing. See appsignal/probes-rs#39 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel 4.18+ appends four more fields for discard
tracking putting the total at 18:
15 - discards completed successfully
16 - discards merged
17 - sectors discarded
18 - time spent discarding
This commit makes the readout compatible with these new fields, but does not read them.
Fixes https://github.com/appsignal/support/issues/10