Fix broken Node builds #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using npm version 7 seems to avoid a bug where the build for the `@appsignal/nodejs` package is not ran before `npm install`, causing the installation to fail as it depends on the Transmitter, which needs to be transpiled first. The bug seems similar to [npm/cli#4552][bug], although that seems to be fixed in npm 8.10.0, and upgrading to that version did not fix the problem. I have been unable to reproduce the bug outside of Semaphore CI, which further complicates investigating it.
Node 15 is deprecated, so npm loudly complains about it during the installation process. This is not, in itself, the cause of the broken builds, but it is misleading and pollutes the output. This commit upgrades all Node-based Dockerfiles to Node 16.
luismiramirez
approved these changes
May 30, 2022
tombruijn
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the builds for the
express-apollo,koaandnext-jstest setups, which are currently broken on main.Pin broken builds to npm version 7
Using npm version 7 seems to avoid a bug where the build for the
@appsignal/nodejspackage is not ran beforenpm install, causing the installation to fail as it depends on the Transmitter, which needs to be transpiled first.The bug seems similar to npm/cli#4552, although that seems to be fixed in npm 8.10.0, and upgrading to that version did not fix the problem. I have been unable to reproduce the bug outside of Semaphore CI, which further complicates investigating it.
Update Node 15 builds to nearest Node LTS
Node 15 is deprecated, so npm loudly complains about it during the installation process. This is not, in itself, the cause of the broken builds, but it is misleading and pollutes the output.
This commit upgrades all Node-based Dockerfiles to Node 16.