fix: Update ChartWidget fontFamily handling to respect system default (…

…#38784)
appsmithorg · Jan 21, 2025 · 16e121c · 16e121c
1 parent c223c50
commit 16e121c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/client/src/widgets/ChartWidget/widget/index.test.ts b/app/client/src/widgets/ChartWidget/widget/index.test.ts
@@ -54,7 +54,7 @@ describe("emptyChartData", () => {
   };
 
   describe("font family", () => {
-    it("uses theme font family with Nunito Sans fallback", () => {
+    it("Does not use any font family as a fallback", () => {
       const widget = new ChartWidget(defaultProps);
       const view = widget.renderChartWithData();
 
@@ -69,7 +69,7 @@ describe("emptyChartData", () => {
       ).renderChartWithData();
 
       expect(viewWithoutFont.props.children.props.fontFamily).toEqual(
-        "Nunito Sans",
+        undefined,
       );
     });
   });

diff --git a/app/client/src/widgets/ChartWidget/widget/index.tsx b/app/client/src/widgets/ChartWidget/widget/index.tsx
@@ -257,7 +257,11 @@ class ChartWidget extends BaseWidget<ChartWidgetProps, WidgetState> {
           customEChartConfig={this.props.customEChartConfig}
           customFusionChartConfig={this.props.customFusionChartConfig}
           dimensions={this.props}
-          fontFamily={this.props.fontFamily ?? "Nunito Sans"}
+          fontFamily={
+            this.props.fontFamily !== "System Default"
+              ? this.props.fontFamily
+              : undefined
+          }
           hasOnDataPointClick={Boolean(this.props.onDataPointClick)}
           isLoading={this.props.isLoading}
           isVisible={this.props.isVisible}