Skip to content

Commit

Permalink
fix: Show bindings hiding behind scroll (#38553)
Browse files Browse the repository at this point in the history
  • Loading branch information
hetunandu authored Jan 9, 2025
1 parent 4662317 commit c302b64
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ import { getIsDraggingOrResizing } from "selectors/widgetSelectors";
import { selectedWidgetsPresentInCanvas } from "selectors/propertyPaneSelectors";
import WalkthroughContext from "components/featureWalkthrough/walkthroughContext";
import { MAIN_CONTAINER_WIDGET_ID } from "constants/WidgetConstants";
import { selectCombinedPreviewMode } from "selectors/gitModSelectors";

export const PROPERTY_PANE_ID = "t--property-pane-sidebar";

export const PropertyPaneSidebar = memo(() => {
const sidebarRef = useRef<HTMLDivElement>(null);
const prevSelectedWidgetId = useRef<string | undefined>();
const isPreviewMode = useSelector(selectCombinedPreviewMode);

const selectedWidgetIds = useSelector(getSelectedWidgets);
const isDraggingOrResizing = useSelector(getIsDraggingOrResizing);
Expand All @@ -31,6 +33,7 @@ export const PropertyPaneSidebar = memo(() => {
//the current selected WidgetId is not equal to previous widget id,
//then don't render PropertyPane
const shouldNotRenderPane =
isPreviewMode ||
(isDraggingOrResizing &&
selectedWidgetIds[0] !== prevSelectedWidgetId.current) ||
selectedWidgetIds[0] === MAIN_CONTAINER_WIDGET_ID;
Expand Down
1 change: 0 additions & 1 deletion app/client/src/pages/Editor/IDE/Layout/StaticLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ const GridContainer = styled.div`
const LayoutContainer = styled.div<{ name: string }>`
position: relative;
grid-area: ${(props) => props.name};
overflow: auto;
`;

export const StaticLayout = React.memo(() => {
Expand Down

0 comments on commit c302b64

Please sign in to comment.