Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]-[21]:Audio recorder does not reset UI when a recording is taking place #14693

Closed
1 task done
ramsaptami opened this issue Jun 20, 2022 · 7 comments · Fixed by #32747
Closed
1 task done

[Bug]-[21]:Audio recorder does not reset UI when a recording is taking place #14693

ramsaptami opened this issue Jun 20, 2022 · 7 comments · Fixed by #32747
Assignees
Labels
Audio Recorder Widget Issues related to Audio Recorder Widget Bug Something isn't working Good First Issue Good for newcomers hacktoberfest All issues that can be solved by the community during Hacktoberfest Low An issue that is neither critical nor breaks a user flow Production UI Improvement Widget Property Issues related to adding / modifying widget properties across widgets Widget Validation Issues related to widget property validation Widgets Product This label groups issues related to widgets

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented Jun 20, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

When audio recorder/camera widget on video mode are reset while they are recording then the widget continues to record without any changes occurring on the UI, i.e. the UI continues to record.

Steps To Reproduce

  1. Using a binding as follows on a button widget's trigger field
    {{resetWidget("AudioRecorder1",true).then(() => showAlert('success'))}}
  2. Add a an audio recorder and text widget to the canvas
  3. Bind internal widget properties of the audio recorder to the text widget as seen in the video
  4. Click on the record on the audio recorder and then click on the button widget - observe the success toast displayed but audio recorder continues to record
  5. When recorder is paused or stopped then the widget resets as expected
  6. Similar behaviour is observed with the camera widget on video mode - but UI retains ok and discard icons even after a reset as seen in issue [Bug]-[64]:Resetting audio and video widget resets playState values but widget UI does not change play state #14692

https://www.loom.com/share/0122d91c7ed345fa8493f8a149e79e29

Public Sample App

No response

Version

Cloud

@ramsaptami ramsaptami added Bug Something isn't working UI Improvement High This issue blocks a user from building or impacts a lot of users Production Needs Triaging Needs attention from maintainers to triage Widget Validation Issues related to widget property validation Audio Recorder Widget Issues related to Audio Recorder Widget Widget Property Issues related to adding / modifying widget properties across widgets labels Jun 20, 2022
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jun 20, 2022
@somangshu somangshu removed the Needs Triaging Needs attention from maintainers to triage label Jun 21, 2022
@dilippitchika
Copy link
Contributor

Assuming 30% of audio rec widgets get reset either via form or directly

Stats

Stat Values
Reach 21
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Audio recorder does not reset UI when a recording is taking place [Bug]-[84]:Audio recorder does not reset UI when a recording is taking place Jun 30, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Audio recorder does not reset UI when a recording is taking place [Bug]-[84]:Audio recorder does not reset UI when a recording is taking place Jun 30, 2022
@dhruvikn dhruvikn added Good First Issue Good for newcomers hacktoberfest All issues that can be solved by the community during Hacktoberfest labels Sep 21, 2022
@dilippitchika dilippitchika added Low An issue that is neither critical nor breaks a user flow and removed High This issue blocks a user from building or impacts a lot of users labels Feb 16, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]-[84]:Audio recorder does not reset UI when a recording is taking place [Bug]-[21]:Audio recorder does not reset UI when a recording is taking place Feb 16, 2023
@dilippitchika
Copy link
Contributor

Workaround exists to stop the recording and then click on reset

@wisewizardofthestars
Copy link

Can I try to work on this issue?

@Nikhil-Nandagopal
Copy link
Contributor

@wisewizardofthestars yeah sure please go for it

@akshat8605
Copy link
Contributor

Is this issue still open? Can it be assigned to me?

@ramsaptami
Copy link
Contributor Author

please go for it @akshat8605

@akshat8605
Copy link
Contributor

@ramsaptami please review the changes. I have changed the blogURL value to null when the recording starts.

somangshu pushed a commit that referenced this issue Apr 19, 2024
… place #14693 (#32747)

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #14693
_or_  
Fixes #14693
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

media :
https://www.loom.com/share/fb1c08173024427d96e483e782d41ee3?sid=49f2fdd8-ca3f-449f-ad09-aec8b294642a

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the Audio Recorder Widget to reset the blob URL property to
`null` after use, enhancing the control flow and logic for handling
audio recordings.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Recorder Widget Issues related to Audio Recorder Widget Bug Something isn't working Good First Issue Good for newcomers hacktoberfest All issues that can be solved by the community during Hacktoberfest Low An issue that is neither critical nor breaks a user flow Production UI Improvement Widget Property Issues related to adding / modifying widget properties across widgets Widget Validation Issues related to widget property validation Widgets Product This label groups issues related to widgets
Projects
None yet
8 participants