Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Remove unnecessary traces and spans from observability stack #24757

Closed
1 task done
nidhi-nair opened this issue Jun 22, 2023 · 0 comments · Fixed by #24758
Closed
1 task done

[Task]: Remove unnecessary traces and spans from observability stack #24757

nidhi-nair opened this issue Jun 22, 2023 · 0 comments · Fixed by #24758
Assignees
@nidhi-nair
Labels
Backend This marks the issue or pull request to reference server code Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform DevOps Pod Issues related to devops Observability Issues related to observability on the Appsmith instance Query & JS Pod Issues related to the query & JS Pod Task A simple Todo

Comments

@nidhi-nair
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

  • Remove the actuator endpoints from being tracked
  • Remove Spring Security, Redis or any other non-Appsmith spans from being added to Tempo aggregate
@nidhi-nair nidhi-nair added Backend This marks the issue or pull request to reference server code Task A simple Todo Observability Issues related to observability on the Appsmith instance labels Jun 22, 2023
@nidhi-nair nidhi-nair self-assigned this Jun 22, 2023
@github-actions github-actions bot added the DevOps Pod Issues related to devops label Jun 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in DevOps Pod Jun 22, 2023
@nidhi-nair nidhi-nair mentioned this issue Jun 22, 2023
Merged
9 tasks
@nidhi-nair nidhi-nair added the Core Query Execution Issues related to the execution of all queries label Jun 23, 2023
@github-actions github-actions bot added Data Platform Pod Issues related to the underlying data platform Query & JS Pod Issues related to the query & JS Pod labels Jun 23, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in DevOps Pod Jun 27, 2023
nidhi-nair added a commit that referenced this issue Jun 27, 2023
@nidhi-nair
chore: Removed spring security and redis traces (#24758)
895ef52 
## Description
Adds a filter for http endpoints that are recorded in our traces. We
have discarded the actuator endpoints since we don't care about their
metrics.

We have also filtered spans to only contain the ones that we have
manually declared across the project. All spans need to use the
`appsmith.` prefix to pass through this filter. This change discards
spring security and redis spans as of today.

Fixes #24757

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nidhi-nair nidhi-nair

Labels
Backend This marks the issue or pull request to reference server code Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform DevOps Pod Issues related to devops Observability Issues related to observability on the Appsmith instance Query & JS Pod Issues related to the query & JS Pod Task A simple Todo
Projects
No open projects
DevOps Pod
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Removed spring security and redis traces appsmithorg/appsmith
1 participant
@nidhi-nair