Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Unable to right click on the link present in URL column type of table widget #24769

Closed
1 task done
keyurparalkar opened this issue Jun 23, 2023 · 4 comments · Fixed by #37179
Closed
1 task done

[Bug]: Unable to right click on the link present in URL column type of table widget #24769

keyurparalkar opened this issue Jun 23, 2023 · 4 comments · Fixed by #37179
Assignees
@rahulbarwal @keyurparalkar @dilippitchika
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@keyurparalkar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When a column is of type URL, it is observed that we cannot right click on the link.

Steps To Reproduce

  1. Dnd table and bind a data to it such that it has a URL column type.
  2. Observe that you cannot right click on the links present in this column type

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud
@keyurparalkar keyurparalkar added Bug Something isn't working Table Widget Needs Triaging Needs attention from maintainers to triage labels Jun 23, 2023
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Jun 23, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added Production Medium Issues that frustrate users due to poor UX labels Mar 2, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
@jacquesikot
Copy link
Contributor

I can right click on a URL link in the table column type.

@hilton
Copy link

hilton commented Oct 31, 2024

How was this fixed? I think we have the same issue. The URL type values are not implemented as HTML a elements, which means that right-clicking doesn’t offer browser functionality for links: copying the URL and choosing whether to open the link in the same/different tab.

Related: URL column values seem to always open in a new tab, which annoys our users.

@rahulbarwal
Copy link
Contributor

@hilton Thanks for clarifying, you are correct, this is not working right now. we will prioritize this.

@rahulbarwal rahulbarwal reopened this Nov 1, 2024
@rahulbarwal rahulbarwal self-assigned this Nov 1, 2024
@rahulbarwal rahulbarwal mentioned this issue Nov 1, 2024
Merged
2 tasks
rahulbarwal added a commit that referenced this issue Nov 1, 2024
@rahulbarwal
[Bug]: Unable to right click on the link present in URL column type o…
2ffbe75 
…f table widget

Fixes #24769
@hilton
Copy link

hilton commented Nov 1, 2024

@rahulbarwal Thanks for the update. Depending on how you resolve this, that might also resolve feature request #37174.

@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 6, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Nov 6, 2024
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 20, 2024
@rahulbarwal
fix: Enhance URL handling in table by rendering URL column types with…
8b6baf6 
… `<a>` tag. (appsmithorg#37179)

## Description
<ins>Problem</ins>

URLs in table were not being rendered as links, resulting in
inconsistent user experience(missing context menus.

<ins>Root cause</ins>

URLs were rendered in `<div>` instead of `<a>`, making the component
lack links related features..

<ins>Solution</ins>

This PR handles... 

- Rendering URLs as links in BasicCell for a better user experience.
- Adding specific types for column properties for more robust data
validation and type checking.
- Adding unit tests for BasicCell functionality to ensure accurate
rendering and behavior.

- Simplifies the AutoToolTipComponent by removing unncessary
`LinkWrapper` component


Fixes appsmithorg#24769
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11681339029>
> Commit: b7c5d17
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11681339029&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Tue, 05 Nov 2024 10:23:38 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Enhanced type safety for `compactMode` and `columnType` properties
across various components.
- Improved rendering logic in the `AutoToolTipComponent` for better
control based on `columnType`.
	- Optimized rendering in the `BasicCell` component using `useMemo`.

- **Bug Fixes**
- Resolved inconsistencies in type definitions for `BasicCell`,
`PlainTextCell`, and `SelectCell` components.
- Updated tooltip behavior in the `AutoToolTipComponent` to ensure
accurate rendering.

- **Tests**
- Introduced a new test suite for the `BasicCell` component, ensuring
proper rendering and interaction behaviors.
- Refined test cases for the `AutoToolTipComponent` to verify accurate
rendering under various conditions.
- Updated test case for URL column verification to check attributes
directly instead of navigation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulbarwal rahulbarwal

@keyurparalkar keyurparalkar

@dilippitchika dilippitchika

Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enhance URL handling in table by rendering URL column types with <a> tag. appsmithorg/appsmith
7 participants
@hilton @Nikhil-Nandagopal @rahulbarwal @keyurparalkar @dilippitchika @jacquesikot @appsmith-bot