Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Unnecessary scroll in a couple of areas in split panes #31573

Closed
1 task done
shadabbuchh opened this issue Mar 7, 2024 · 0 comments · Fixed by #37203
Closed
1 task done

[Bug]: Unnecessary scroll in a couple of areas in split panes #31573

shadabbuchh opened this issue Mar 7, 2024 · 0 comments · Fixed by #37203
Assignees
@hetunandu @rohan-arthur
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention UI Improvement

Comments

@shadabbuchh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

We have come across areas that have an unnecessary scroll. It doe not add value.

Screen.Recording.2024-03-06.at.10.03.15.AM.mov

Steps To Reproduce

  1. Login with the below credentials in release:
    -username: ide-test@appsmith.com
    -password: ide-test@appsmith.com
  2. Add some queries.

You'll notice we get to see scroll that are not needed in a couple of places

Public Sample App

No response

Environment

Release

Severity

Low (Inconsistent UI/UX)

Issue video log

No response

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working UI Improvement Low An issue that is neither critical nor breaks a user flow Release Needs Triaging Needs attention from maintainers to triage IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Mar 7, 2024
@github-actions github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Mar 7, 2024
@btsgh btsgh added Production and removed Release labels Mar 27, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the IDE Product Issues related to the IDE Product label Aug 5, 2024
@hetunandu hetunandu mentioned this issue Nov 5, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 5, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Nov 5, 2024
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 20, 2024
@hetunandu @coderabbitai
fix: Paddings and scrolls in Plugin Action Editor (appsmithorg#37203)
b70d985 
## Description

Updates the padding and fixes the unnecessary scrolls renders in the new
Plugin Action Editor flow



Fixes appsmithorg#31573
Fixes appsmithorg#37214

## Automation

/ok-to-test tags="@tag.Datasource"




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new `TabbedViewContainer` for improved layout in the
`CommonEditorForm`.
- Added support for binary file uploads in the `PostBodyData` component.

- **Improvements**
- Enhanced padding and border behavior in the `Section` component based
on the new `withoutPadding` attribute.
- Adjusted minimum height for the `.CodeMirror` class in the
`PostBodyData` component.
- Improved layout and styling in the `InfoFields` component with new
styled components.
- Updated tooltip content handling in the `DatasourceConfig` component
for better clarity on invalid entries.
- Refined layout behavior in the `CommonEditorForm` with the addition of
the `TabbedViewContainer`.
- Enhanced layout in the `EmbeddedDatasourcePathField` component with
updated styling.

- **Bug Fixes**
	- No new bug fixes reported.

- **Refactor**
- Streamlined the `RequestTabs` component by integrating styles directly
into the `Tabs` component.
- Refined handling of datasource URLs in the
`EmbeddedDatasourcePathField` component.
- Updated styling and structure in the `KeyValueFieldArray` component
for improved layout.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention UI Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Paddings and scrolls in Plugin Action Editor appsmithorg/appsmith
6 participants
@Nikhil-Nandagopal @hetunandu @shadabbuchh @appsmith-bot @rohan-arthur @btsgh