Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: currentRow not accesible inside certain fields within the Currency column of Table #33858

Closed
1 task done
tomjose92 opened this issue May 30, 2024 · 0 comments · Fixed by #33877
Closed
1 task done

[Bug]: currentRow not accesible inside certain fields within the Currency column of Table #33858

tomjose92 opened this issue May 30, 2024 · 0 comments · Fixed by #33877
Assignees
@Nikhil-Nandagopal @somangshu
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@tomjose92
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

A user reported that he is unable to refer to currentRow inside the field Currency when the column is configured to the type currency inside the Table widget.
Additionally I verified, currentRow is not accessible inside the JS configurable fields Thousand separator and Notation as well.

It works else where within the same Currency column type in fields like inside Visible, Editable, etc

Attached screenshot below
Screenshot 2024-05-30 at 8 24 01 PM

Steps To Reproduce

  1. Introduce a table widget and set it with some data
  2. Configure one of the columns to be of type Currency
  3. Try to access currentRow in its JS configurable fields like Currency, Thousand separator or Notation

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud / Self Hosted - 1.26
@tomjose92 tomjose92 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Table Widget V2 Issues related to Table Widget V2 labels May 30, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Medium Issues that frustrate users due to poor UX Production labels May 30, 2024
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets labels May 30, 2024
@jsartisan jsartisan mentioned this issue May 31, 2024
Merged
jsartisan added a commit that referenced this issue May 31, 2024
@jsartisan
fix: add customJS control for currency, notation and thousand separat…
eb0c13d 
…or (#33877)

Fixes #33858

/ok-to-test tags="@tag.Table"<!-- This is an auto-generated comment:
Cypress test results -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9318008514>
> Commit: 1ea0a63
> Workflow: `PR Automation test suite`
> Tags: `@tag.Table`

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 31, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 31, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@somangshu somangshu

Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add customJS control for currency, notation and thousand separator appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @tomjose92 @somangshu @appsmith-bot