Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Tests for DnD sagas. #33981

Closed
marks0351 opened this issue Jun 5, 2024 · 0 comments · Fixed by #34407
Closed

Task: Tests for DnD sagas. #33981

marks0351 opened this issue Jun 5, 2024 · 0 comments · Fixed by #34407
Assignees
Labels
Anvil Pod Issue related to Anvil project Task A simple Todo

Comments

@marks0351
Copy link
Contributor

Unit Tests:
Test: anvilDraggingSagas
New Widget DnD

  • adds new widget on to the main canvas
  • adds new widget into an existing section
  • adds new widget into an existing zone
  • triggeres anvil updates and recomputes zone count and space distribution on saving the dsl
  • selects newly added widget after adding it to the canvas

Move exitsing Widgets DnD

  • move widget on to the main canvas
  • move widget on to an existing section
  • move widget on to an existing zone
  • triggeres anvil updates and recomputes zone count and space distribution on saving the dsl
  • handles multiple widgets moved at once
@marks0351 marks0351 added the Anvil Pod Issue related to Anvil project label Jun 5, 2024
@marks0351 marks0351 self-assigned this Jun 5, 2024
@marks0351 marks0351 added this to the Anvil test coverage - R1 milestone Jun 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jun 5, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Jul 10, 2024
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1IH0H4UjkYrlztX0lkyWZ1n2uZYh8Epg%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=Pmk6xa9)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes appsmithorg#33981
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9639877981>
> Commit: 311f59c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9639877981&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Introduced test cases for adding and moving widgets within a canvas
layout.

- **New Features**
- Added functionality to generate mock data for a layout with two
sections, each containing a zone widget.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Task A simple Todo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants