Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix flakiness of cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts #35144

Closed
NilanshBansal opened this issue Jul 24, 2024 · 6 comments
Closed

[Task]: Fix flakiness of cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts #35144

NilanshBansal opened this issue Jul 24, 2024 · 6 comments
Assignees
@NilanshBansal
Labels
cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

Ref: https://theappsmith.slack.com/archives/C06FWBV74GH/p1715864802943759?thread_ts=1715842923.212549&cid=C06FWBV74GH
Because of update has not finished and same warnings on the body when js body was replaced warnings moved because of replacement and annotation were displaced
Failure Runs: https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?workflowId=9110516373&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail
@NilanshBansal NilanshBansal added the Task A simple Todo label Jul 24, 2024
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jul 24, 2024
This was referenced Jul 24, 2024
Closed
Closed
Closed
Closed
Closed
@NilanshBansal
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @AmanAgarwal041 @carinanfonseca @rishabhrathod01 @rohan-arthur @sneha122

@github-actions github-actions bot mentioned this issue Jul 24, 2024
Closed
@NilanshBansal NilanshBansal removed the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jul 24, 2024
@NilanshBansal NilanshBansal self-assigned this Jul 24, 2024
@NilanshBansal NilanshBansal added Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release labels Jul 25, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Stability Pod For all issues/tasks to be prioritized under Stability pod labels Jul 25, 2024
@NilanshBansal
Copy link
Contributor Author

NilanshBansal commented Jul 29, 2024 •
edited
Loading

@RakshaKShetty @yatinappsmith the cypress dashboard failure run attached in this test does not have any screenshots or video available?
Do we delete the media files of the old runs? How can I check the media files of this run?

image image

@NilanshBansal
Copy link
Contributor Author

NilanshBansal commented Jul 29, 2024 •
edited
Loading

As per discussion with @yatinappsmith, since this run is from 2 months ago and we only store the media files for last 15 days of cypress runs, there is no way to check the recordings or screenshot back.
cc: @rohan-arthur

@NilanshBansal NilanshBansal mentioned this issue Jul 29, 2024
Closed
2 tasks
@NilanshBansal
Copy link
Contributor Author

The test is passing in the CE and EE PRs.
CE Run 1
CE Run 2
EE Run 1
EE Run 2

This is not flaky and was fixed in the PR #33545
Confirmed with @dvj1988

@NilanshBansal
Copy link
Contributor Author

NilanshBansal commented Jul 29, 2024 •
edited
Loading

@yatinappsmith @RakshaKShetty I have removed cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts test from the list of flaky cypress tests.

@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: added test to limited tests list appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @NilanshBansal