Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix flakiness of cypress/e2e/Regression/ClientSide/BugTests/GraphQL_Binding_Bug16702_Spec.ts #35147

Closed
NilanshBansal opened this issue Jul 24, 2024 · 3 comments · Fixed by #35571
Closed

[Task]: Fix flakiness of cypress/e2e/Regression/ClientSide/BugTests/GraphQL_Binding_Bug16702_Spec.ts #35147

NilanshBansal opened this issue Jul 24, 2024 · 3 comments · Fixed by #35571
Assignees
@sneha122
Labels
cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

Spec has one test and it has been skipped. if it is not relevant anymore, then remove it.
@NilanshBansal NilanshBansal added the Task A simple Todo label Jul 24, 2024
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jul 24, 2024
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
This was referenced Jul 24, 2024
Closed
Closed
Closed
@NilanshBansal
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @AmanAgarwal041 @carinanfonseca @rishabhrathod01 @rohan-arthur @sneha122

@github-actions github-actions bot mentioned this issue Jul 24, 2024
Closed
@NilanshBansal NilanshBansal removed the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jul 24, 2024
@NilanshBansal NilanshBansal added Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release labels Jul 25, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Stability Pod For all issues/tasks to be prioritized under Stability pod labels Jul 25, 2024
@sneha122
Copy link
Contributor

sneha122 commented Aug 1, 2024

Moving this to sprint backlog to in order to prioritise adding sysout logs for this issue

@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
@sneha122 sneha122 mentioned this issue Aug 9, 2024
Merged
2 tasks
sneha122 added a commit that referenced this issue Aug 14, 2024
@sneha122
test: fixed skipped graphQL test (#35571)
37b5225 
## Description

**Context:**
This cypress test is asserting the fixes made for
[bug](#16702)
Bug recording:
https://www.loom.com/share/ccf9fccc89064ee7b4230aaf5bf3cc52

Basically bug was that when using bindings inside query of graphQL API,
autocomplete menu shows up for first binding, but not for second
binding. This test case asserts that autocomplete menu shows up every
time inside binding for query

EE PR: appsmithorg/appsmith-ee#4856

This PR fixes the skipped test of spec file:
cypress/e2e/Regression/ClientSide/BugTests/GraphQL_Binding_Bug16702_Spec.ts


Fixes #35147 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10383572807>
> Commit: 0a655d7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10383572807&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Wed, 14 Aug 2024 09:15:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **Bug Fixes**
- Updated the test for a GraphQL binding issue, now actively validating
the resolution of a formatting bug that affected autocomplete
functionality.
- Enhanced test clarity by removing redundant code and optimizing the
test flow for improved execution efficiency.
- **Chores**
- Changed the focus of the limited test scenario to prioritize
addressing the GraphQL binding bug over template-related
functionalities.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sneha122 sneha122

Labels
cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fixed skipped graphQL test appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @NilanshBansal @sneha122