Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add Zone & Section to SMTP plugin form #35505

Closed
Tracked by #34323
albinAppsmith opened this issue Aug 7, 2024 · 0 comments · Fixed by #36091
Closed
Tracked by #34323

[Task]: Add Zone & Section to SMTP plugin form #35505

albinAppsmith opened this issue Aug 7, 2024 · 0 comments · Fixed by #36091
Assignees
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@albinAppsmith
Copy link
Collaborator

albinAppsmith commented Aug 7, 2024

Design: https://zpl.io/LL4AnnM

@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Aug 7, 2024
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Aug 7, 2024
@albinAppsmith albinAppsmith added IDE Navigation Issues/feature requests related to IDE navigation, and context switching and removed potential-duplicate This label marks issues that are potential duplicates of already open issues labels Aug 7, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot Aug 7, 2024
@albinAppsmith albinAppsmith added IDE Navigation Issues/feature requests related to IDE navigation, and context switching and removed IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Aug 8, 2024
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Aug 8, 2024
@ankitakinger ankitakinger self-assigned this Aug 29, 2024
ankitakinger added a commit that referenced this issue Sep 5, 2024
…tions and zones format (#36091)

## Description

Action redesign: Updating the config for SMTP plugin to use sections and
zones format

Fixes [#35505 ](#35505)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10704929692>
> Commit: f58dfce
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10704929692&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 04 Sep 2024 19:46:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a comprehensive email sending interface in the SMTP plugin,
allowing users to input recipient addresses, subject, body type, and
attachments.
- Enhanced layout with a new `DOUBLE_COLUMN_ZONE` structure for improved
organization of input fields.

- **Improvements**
- Expanded styling capabilities for the dynamic input text control,
allowing for more flexible sizing and better responsiveness in the UI.
- Updated existing configurations to streamline the email composition
process and improve user experience.

- **Bug Fixes**
- Adjusted CSS rules to remove minimum height and width constraints for
better adaptability of UI components.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
…tions and zones format (appsmithorg#36091)

## Description

Action redesign: Updating the config for SMTP plugin to use sections and
zones format

Fixes [appsmithorg#35505 ](appsmithorg#35505)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10704929692>
> Commit: f58dfce
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10704929692&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 04 Sep 2024 19:46:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a comprehensive email sending interface in the SMTP plugin,
allowing users to input recipient addresses, subject, body type, and
attachments.
- Enhanced layout with a new `DOUBLE_COLUMN_ZONE` structure for improved
organization of input fields.

- **Improvements**
- Expanded styling capabilities for the dynamic input text control,
allowing for more flexible sizing and better responsiveness in the UI.
- Updated existing configurations to streamline the email composition
process and improve user experience.

- **Bug Fixes**
- Adjusted CSS rules to remove minimum height and width constraints for
better adaptability of UI components.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
3 participants