-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to make snapshot tests. Prepare environment for snapshot testing. #36419
Labels
Stability Issue
Every issue handle by Stability Pod
Stability Pod
For all issues/tasks to be prioritized under Stability pod
Task
A simple Todo
Comments
KelvinOm
added
QA Pod
Issues under the QA Pod
and removed
Anvil Pod
Issue related to Anvil project
labels
Sep 19, 2024
KelvinOm
changed the title
Make it possible to take snapshot tests. Prepare the environment for snapshot testing
Make it possible to make snapshot tests. Prepare the environment for snapshot testing.
Sep 19, 2024
KelvinOm
changed the title
Make it possible to make snapshot tests. Prepare the environment for snapshot testing.
Make it possible to make snapshot tests. Prepare environment for snapshot testing.
Sep 19, 2024
KelvinOm
added a commit
that referenced
this issue
Sep 19, 2024
## Description Disable all Anvil snapshot tests. The tests will be enabled after solving the #36419. Related thread https://theappsmith.slack.com/archives/C025SE88KNE/p1726721979435589 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10938186194> > Commit: ee5c8f4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938186194&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 19 Sep 2024 11:14:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Temporarily skipped multiple test suites for various Anvil widgets due to unresolved issues, preventing potential false negatives in testing. - Specific tests affected include those for Modal sizes, App Theming, Button, Checkbox, Currency Input, Heading, Icon Button, Inline Button, Input, Paragraph, Phone Input, Radio Group, Stats, Switch Group, Switch, Table, Toolbar Button, and Zone Section Widgets. These adjustments ensure the integrity of the testing process while issues are being addressed. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this issue
Sep 26, 2024
## Description Disable all Anvil snapshot tests. The tests will be enabled after solving the appsmithorg#36419. Related thread https://theappsmith.slack.com/archives/C025SE88KNE/p1726721979435589 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10938186194> > Commit: ee5c8f4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938186194&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 19 Sep 2024 11:14:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Temporarily skipped multiple test suites for various Anvil widgets due to unresolved issues, preventing potential false negatives in testing. - Specific tests affected include those for Modal sizes, App Theming, Button, Checkbox, Currency Input, Heading, Icon Button, Inline Button, Input, Paragraph, Phone Input, Radio Group, Stats, Switch Group, Switch, Table, Toolbar Button, and Zone Section Widgets. These adjustments ensure the integrity of the testing process while issues are being addressed. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions
bot
added
the
Stability Pod
For all issues/tasks to be prioritized under Stability pod
label
Oct 17, 2024
Fixed the chrome version. Re enabling test and verifying results. |
Found pixel mismatch, Writing CI for updating screenshot and store in zip file. |
This was referenced Dec 19, 2024
sagar-qa007
added a commit
that referenced
this issue
Dec 20, 2024
## Description Adding workflow for updating snapshot with github CI. Fixes #[`36419` ](#36419) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12426577557> > Commit: 2660c07 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12426577557&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 20 Dec 2024 07:02:16 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced CI workflow with new input parameters for snapshot updates and spec execution. - Added steps for uploading existing and new snapshot data during Cypress tests. - **Bug Fixes** - Improved artifact management and error handling in the CI process. - **Documentation** - Added comments for better understanding of workflow logic and input parameters. - **Refactor** - Streamlined job execution logic and conditional checks for test reruns. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
sagar-qa007
added a commit
that referenced
this issue
Dec 20, 2024
## Description Uncommenting test cases as chrome browser version has been hardcoded now. Fixes [`Issue URL`](#36419) ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12429832882> > Commit: 6b601b1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12429832882&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 20 Dec 2024 10:59:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled execution of previously skipped test suites for various Anvil widgets, including Checkbox, Button, Input, and others across different modes (Canvas, Preview, Deploy). - Enhanced visual testing capabilities by ensuring all theming configurations (light and dark modes) are validated for each widget. - **Bug Fixes** - Resolved issues causing test suites to be skipped, allowing comprehensive testing of widget functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
NandanAnantharamu
pushed a commit
that referenced
this issue
Dec 27, 2024
## Description Adding workflow for updating snapshot with github CI. Fixes #[`36419` ](#36419) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12426577557> > Commit: 2660c07 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12426577557&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 20 Dec 2024 07:02:16 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced CI workflow with new input parameters for snapshot updates and spec execution. - Added steps for uploading existing and new snapshot data during Cypress tests. - **Bug Fixes** - Improved artifact management and error handling in the CI process. - **Documentation** - Added comments for better understanding of workflow logic and input parameters. - **Refactor** - Streamlined job execution logic and conditional checks for test reruns. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
NandanAnantharamu
pushed a commit
that referenced
this issue
Dec 27, 2024
## Description Uncommenting test cases as chrome browser version has been hardcoded now. Fixes [`Issue URL`](#36419) ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12429832882> > Commit: 6b601b1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12429832882&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 20 Dec 2024 10:59:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled execution of previously skipped test suites for various Anvil widgets, including Checkbox, Button, Input, and others across different modes (Canvas, Preview, Deploy). - Enhanced visual testing capabilities by ensuring all theming configurations (light and dark modes) are validated for each widget. - **Bug Fixes** - Resolved issues causing test suites to be skipped, allowing comprehensive testing of widget functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Stability Issue
Every issue handle by Stability Pod
Stability Pod
For all issues/tasks to be prioritized under Stability pod
Task
A simple Todo
We cannot use snapshot tests, since the local environment and the environment in CI are different.
Related thread:
https://theappsmith.slack.com/archives/C025SE88KNE/p1726734752809939?thread_ts=1726721979.435589&cid=C025SE88KNE
The text was updated successfully, but these errors were encountered: