Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Set datasourceId to executeActionDTO when an action is executed #37627

Closed
nsarupr opened this issue Nov 21, 2024 · 0 comments · Fixed by #37626
Closed

[Task]: Set datasourceId to executeActionDTO when an action is executed #37627

nsarupr opened this issue Nov 21, 2024 · 0 comments · Fixed by #37626
Assignees
@nsarupr
Labels
Anvil Pod Issue related to Anvil project Task A simple Todo

Comments

@nsarupr
Copy link
Contributor

nsarupr commented Nov 21, 2024

No description provided.

@nsarupr nsarupr added the Anvil Pod Issue related to Anvil project label Nov 21, 2024
@nsarupr nsarupr self-assigned this Nov 21, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 21, 2024
@nsarupr nsarupr mentioned this issue Nov 21, 2024
Merged
2 tasks
nsarupr added a commit that referenced this issue Nov 21, 2024
@nsarupr
chore: set datasourceId in executeActionDTO during execution (#37626)
d99789c 
## Description
> Set the correct datasourceId to executeActionDTO when an action is
being executed.

Fixes #37627

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11948824843>
> Commit: 458b5c0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11948824843&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 08:22:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced functionality to set the correct `datasourceId` based on the
action's context, improving action execution accuracy.

- **Refactor**
	- Improved code formatting for clarity without altering existing logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 27, 2024
@nsarupr
chore: set datasourceId in executeActionDTO during execution (appsmit…
8032c0d 
…horg#37626)

## Description
> Set the correct datasourceId to executeActionDTO when an action is
being executed.

Fixes appsmithorg#37627

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11948824843>
> Commit: 458b5c0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11948824843&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 08:22:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced functionality to set the correct `datasourceId` based on the
action's context, improving action execution accuracy.

- **Refactor**
	- Improved code formatting for clarity without altering existing logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsarupr nsarupr

Labels
Anvil Pod Issue related to Anvil project Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: set datasourceId in executeActionDTO during execution appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @nsarupr