Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Git mod - Internal manual testing #37821

Closed
brayn003 opened this issue Nov 29, 2024 · 0 comments · Fixed by #38357
Closed

[Task] Git mod - Internal manual testing #37821

brayn003 opened this issue Nov 29, 2024 · 0 comments · Fixed by #38357
Assignees
@brayn003
Labels
Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo

Comments

@brayn003
Copy link
Contributor

No description provided.

@brayn003 brayn003 added the Packages Pod issues that belong to the packages pod label Nov 29, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 29, 2024
@github-actions github-actions bot added the Packages & Git Pod All issues belonging to Packages and Git label Nov 29, 2024
@brayn003 brayn003 self-assigned this Dec 16, 2024
@brayn003 brayn003 mentioned this issue Dec 31, 2024
Merged
2 tasks
brayn003 added a commit that referenced this issue Jan 7, 2025
@brayn003
chore: git mod - test fixes (#38357)
f6d7ce6 
## Description
- Locator fixes for cy tests
- Missing saga for discard and merge
- New component for hot keys


Fixes #37821
Fixes #37822
Fixes #37824

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12649057943>
> Commit: 94c57d0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12649057943&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Tue, 07 Jan 2025 10:42:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Added repository limit error modal to handle scenarios when repository
limits are reached.
  - Introduced Git hot keys for quick access to Git operations.
- Enhanced Git synchronization functionality with new merge and discard
change capabilities.
- Integrated feature flag handling in test suites for Git-related
functionalities.

- **Improvements**
  - Standardized test identifiers across Git-related components.
  - Refined Git modal interactions and state management.
  - Updated locator references for more consistent testing.
- Improved user feedback with success notifications for branch
deletions.

- **Bug Fixes**
  - Resolved issues with branch switching and URL handling.
  - Improved error handling in Git synchronization processes.

- **Testing**
  - Updated Cypress test suites with new feature flag interceptors.
  - Enhanced test coverage for Git operations and modal interactions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

Labels
Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: git mod - test fixes appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @brayn003