Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Git - After pulling remote changes, the modal does not go away #38454

Open
1 task done
btsgh opened this issue Jan 2, 2025 · 0 comments · May be fixed by #38583
Open
1 task done

[Bug]: Git - After pulling remote changes, the modal does not go away #38454

btsgh opened this issue Jan 2, 2025 · 0 comments · May be fixed by #38583
Assignees
@brayn003 @riteshkew
Labels
Bug Something isn't working Git Product Issues related to version control product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Production

Comments

@btsgh
Copy link
Collaborator

btsgh commented Jan 2, 2025 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

In a git connected app, after making some changes on remote, when I try to pull changes in the app, the changes gets pulled, page refreshes, but the modal does not go away

Steps To Reproduce

  1. Create a git connected app
  2. Create a branch
  3. Make some changes on the repo to this branch
  4. Pull these changes on the app
  5. Note that the modal does not go away post changes are pulled.
    Expected behavior - Post pulling, if there are no changes to commit, we expect the modal to go away.

https://jam.dev/c/4e398881-2902-4a1b-9e5f-bc9f3e8293f2

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud
@btsgh btsgh added Bug Something isn't working Production Needs Triaging Needs attention from maintainers to triage Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX labels Jan 2, 2025
@github-actions github-actions bot added the Packages & Git Pod All issues belonging to Packages and Git label Jan 2, 2025
@btsgh btsgh added Low An issue that is neither critical nor breaks a user flow and removed Medium Issues that frustrate users due to poor UX labels Jan 2, 2025
devin-ai-integration bot added a commit that referenced this issue Jan 10, 2025
@devin-ai-integration @mohanarpit
fix: close Git Ops modal after successful pull (#38454)
8faf828 
Co-Authored-By: arpit@appsmith.com <arpit@appsmith.com>
@devin-ai-integration devin-ai-integration bot linked a pull request Jan 10, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

@riteshkew riteshkew

Labels
Bug Something isn't working Git Product Issues related to version control product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Production
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close Git Ops modal after successful pull appsmithorg/appsmith
3 participants
@brayn003 @riteshkew @btsgh