Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add anchor tag behaviours to edit/launch buttons in applications dasboard #15168

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented Jul 13, 2022

Description

  • Adds href to edit/launch buttons in application dashboard.
  • Added preventDefault to stop full page reload and do client side navigation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 4:57AM (UTC)

@arunvjn arunvjn requested a review from albinAppsmith July 13, 2022 09:24
@arunvjn arunvjn added the IDE Pod Issues that new developers face while exploring the IDE label Jul 13, 2022
@arunvjn
Copy link
Contributor Author

arunvjn commented Jul 13, 2022

/ok-to-test sha=f09410c

@github-actions github-actions bot added the Bug Something isn't working label Jul 13, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

2 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2662400100.
Workflow: Appsmith External Integration Test Workflow.
Commit: f09410c.
PR: 15168.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2662400100.
Commit: f09410c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1155.06 1170.49 1158.98 1184.71 1423.84 1170.49 1218.62 9.46 8.46
painting 6.46 6.87 6.31 7.16 10.18 6.87 7.4 21.49 19.19
rendering 615.39 593.71 597.85 604.76 759.22 604.76 634.19 11.10 9.93
SELECT_WIDGET_SELECT_OPTION
scripting 157.05 153.95 246.52 159.1 199.06 159.1 183.14 21.81 19.50
painting 5.81 4.42 2.58 3.4 6.08 4.42 4.46 33.86 30.27
rendering 10.72 11.2 11.59 11.22 14.61 11.22 11.87 13.14 11.79

@arunvjn
Copy link
Contributor Author

arunvjn commented Jul 13, 2022

/ok-to-test sha=64ed559

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2662863437.
Workflow: Appsmith External Integration Test Workflow.
Commit: 64ed559.
PR: 15168.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2662863437.
Commit: 64ed559.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1152.2 1114.09 1138.15 1100.71 1170.53 1138.15 1135.14 2.48 2.22
painting 11.45 7.7 6.51 7.36 7.9 7.7 8.18 23.23 20.78
rendering 605.83 595.71 600.21 594.9 611.41 600.21 601.61 1.16 1.04
SELECT_WIDGET_SELECT_OPTION
scripting 153.31 155.15 157.25 154.94 155.7 155.15 155.27 0.91 0.82
painting 3.6 4.57 4.73 4.75 4 4.57 4.33 11.78 10.62
rendering 9.89 9.65 10.86 10.26 10.26 10.26 10.18 4.52 4.03

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=3a91faa

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2668013940.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a91faa.
PR: 15168.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2668013940.
Commit: 3a91faa.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1131.15 1113.8 1125.12 1156.29 1102.38 1125.12 1125.75 1.81 1.61
painting 5.62 9.26 6.49 6.84 6.46 6.49 6.93 19.91 17.75
rendering 597.81 589.14 603.69 602.67 597.68 597.81 598.2 0.96 0.86
SELECT_WIDGET_SELECT_OPTION
scripting 148.6 154.81 147.64 147.94 160.76 148.6 151.95 3.78 3.38
painting 3.42 7.01 5.45 8.87 3.47 5.45 5.64 41.49 37.23
rendering 9.39 9.95 8.52 9.5 9.8 9.5 9.43 5.94 5.30

@arunvjn arunvjn merged commit c331f8c into release Jul 14, 2022
@arunvjn arunvjn deleted the fix/edit-launch-app-links branch July 14, 2022 07:04
berabhishek pushed a commit to berabhishek/appsmith that referenced this pull request Jul 25, 2022
@hetunandu hetunandu mentioned this pull request Jan 22, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants