-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: prioritize the main bundle over <link rel=preload>
s
#23556
Closed
Closed
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0604ee4
perf: prioritize the main bundle over <link rel=preload>s
iamakulov 5d7d891
Make the bundle code agnostic to whether it executes in <body> or <head>
iamakulov 2ceca1a
Merge branch 'release' into perf/prioritize-bundle
3317cf1
Merge branch 'release' into perf/prioritize-bundle
f6612b2
Merge remote-tracking branch 'origin/release' into perf/prioritize-bu…
iamakulov 0cca5bf
Remove the `defer` attribute during development as well
iamakulov 827855d
Remove `appInitializer()` duplicated during merging + move `setAutoFr…
iamakulov 46e1168
update ds-old version
tanvibhakta ec1c1bc
Merge branch 'release' into perf/prioritize-bundle
tanvibhakta 4263440
Merge branch 'release' into perf/prioritize-bundle
iamakulov c22ac38
Fix the header not being rendered
iamakulov 64242b8
Merge remote-tracking branch 'origin/release' into perf/prioritize-bu…
iamakulov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamakulov , What happens if we put this main at the end of body? Does it have to compete for bandwidth with preloads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this request was scheduled late-ish in my tests (due to being discovered later), and one or two
<link rel="preload">
stole its bandwidth. I’ll re-run the tests and get back with waterfalls in a bit!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, re-ran the tests. With
<script>
in the end of<head>
(as in this PR), themain
bundle takes 2.1s (request 5):HTML code
With script in the end of
<body>
, the main bundle takes 3s (request 6):HTML code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that the script is in the end of
<head>
in the first test. We can move it to the beginning of<head>
, but that’s