chore: Remove unreadCommentThreads

[sharat87]

Not removing this field from Cypress test resources, so that we continue to test with past export files.

/test all

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9344945556
Commit: b97cece
Cypress dashboard url: Click here!

[coderabbitai]

Walkthrough

Walkthrough

The recent changes involve the removal of the unreadCommentThreads property from both the UpdateApplicationResponse interface in the frontend and the Application class in the backend. This alteration simplifies the data structure and response objects related to application updates by eliminating the now-unnecessary property.

Changes

Files	Change Summary
app/client/src/ce/api/ApplicationApi.tsx	Removed the unreadCommentThreads property from the UpdateApplicationResponse interface.
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Application.java	Removed the unreadCommentThreads field annotated with @Transient and @JsonView(Views.Public.class).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d8c38f and b97cece.

Files selected for processing (2)

• app/client/src/ce/api/ApplicationApi.tsx (1 hunks)
• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Application.java (1 hunks)

Files skipped from review due to trivial changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Application.java

Additional context used

Biome

app/client/src/ce/api/ApplicationApi.tsx

[error] 168-168: Unexpected any. Specify a different type.

---

[error] 177-177: Unexpected any. Specify a different type.

---

[error] 281-500: Avoid classes that contain only static members.

---

[error] 307-307: Unexpected any. Specify a different type.

---

[error] 308-308: Template literals are preferred over string concatenation.

---

[error] 314-314: Template literals are preferred over string concatenation.

---

[error] 320-320: Template literals are preferred over string concatenation.

---

[error] 335-335: Template literals are preferred over string concatenation.

---

[error] 371-371: Template literals are preferred over string concatenation.

---

[error] 377-377: Template literals are preferred over string concatenation.

---

[error] 384-388: Template literals are preferred over string concatenation.

---

[error] 424-424: Template literals are preferred over string concatenation.

---

[error] 439-439: Template literals are preferred over string concatenation.

---

[error] 454-454: Template literals are preferred over string concatenation.

Additional comments not posted (2)

app/client/src/ce/api/ApplicationApi.tsx (2)

Line range hint 308-308: Use template literals instead of string concatenation for better readability and performance.
[REFACTOR_SUGGESTion]

- ApplicationApi.baseURL + "/home?workspaceId=" + workspaceId
+ `${ApplicationApi.baseURL}/home?workspaceId=${workspaceId}`

Also applies to: 314-314, 320-320, 335-335, 371-371, 377-377, 384-388, 424-424, 439-439, 454-454

---

Line range hint 168-168: The removal of unreadCommentThreads from UpdateApplicationResponse aligns with the PR's objectives and does not introduce any immediate issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

app/client/src/ce/api/ApplicationApi.tsx (2)

Line range hint 168-168: Replace any type with more specific types to improve type safety.

- Promise<any>
+ Promise<SpecificType> // Replace `SpecificType` with the actual expected type

Also applies to: 177-177, 307-307

---

Line range hint 281-500: Consider refactoring the ApplicationApi class to avoid a class that only contains static methods. This could potentially be a utility module.