chore: Don't include new in responses

[sharat87]

This field isn't used on client and so shouldn't be sent across.

/test sanity

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9756721589
Commit: ea11761
Cypress dashboard.
Tags: @tag.Sanity

Summary by CodeRabbit

• Bug Fixes

  • Improved data handling by modifying visibility annotations, enhancing security and data privacy.

• Tests

  • Updated tests to align with changes in data visibility, ensuring accurate validation of JSON responses.

[coderabbitai]

Walkthrough

The recent updates involve modifying the visibility of the isNew() method in the BaseDomain class by replacing its @JsonView annotation with @JsonIgnore. This change affects the test case in CommonConfigTest.java: an assertion for the "new" field in a JSON response has been removed.

Changes

File Path	Summary
app/.../BaseDomain.java	Replaced @JsonView(Views.Public.class) with @JsonIgnore for isNew() method.
app/.../CommonConfigTest.java	Removed assertion for the "new": true field in the JSON response test.

Poem

In lines of code we chisel,
A tiny change, a little drizzle.
@JsonView bowing out with grace,
@JsonIgnore now takes its place.
Tests refined, their burden eased,
Our program runs, more pleased. 🌟🐇

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.configurations.CommonConfigTest#objectMapper_BeanCreated_WithPublicJsonViewAsDefault

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 55b6e6d and ea11761.

Files selected for processing (2)

• app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/BaseDomain.java (2 hunks)
• app/server/appsmith-server/src/test/java/com/appsmith/server/configurations/CommonConfigTest.java (1 hunks)

Files skipped from review due to trivial changes (1)

• app/server/appsmith-server/src/test/java/com/appsmith/server/configurations/CommonConfigTest.java

Additional comments not posted (1)

app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/BaseDomain.java (1)

82-84: LGTM! But verify the impact on JSON responses.

The change from @JsonView(Views.Public.class) to @JsonIgnore for the isNew() method is correct and aligns with the PR objective to remove the new field from responses.

However, ensure that this method is not required in any JSON responses elsewhere in the codebase.

Verification successful

---

LGTM! But verify the impact on JSON responses.

The change from @JsonView(Views.Public.class) to @JsonIgnore for the isNew() method is correct and aligns with the PR objective to remove the new field from responses.

There are no references to the isNew() method elsewhere in the codebase, ensuring that this change does not impact any JSON responses.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the impact of the `isNew()` method change on JSON responses.

# Test: Search for the usage of the `isNew()` method in the codebase. Expect: No critical dependencies on JSON responses.
rg --type java $'isNew'

Length of output: 3802

---

---

Script:

#!/bin/bash
# Description: Verify the impact of the `isNew()` method change on JSON responses.

# Test: Search for references to the `isNew()` method in the codebase to identify any JSON serialization dependencies.
rg --type java 'isNew\('

Length of output: 145