Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added wrap for overflowing editor content #35262

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Jul 29, 2024

Description

Horizontal scroll was not enabled in JS object side by side view. To fix the content overflowing issue, this PR added word wrap by limiting the width of the editor.

Fixes #35240

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10143519420
Commit: ce0fcc9
Cypress dashboard.
Tags: @tag.All
Spec:


Mon, 29 Jul 2024 13:03:04 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Enhancements
    • Improved the layout of the JSEditor component for better responsiveness and alignment by ensuring it takes the full width of its container.

Copy link
Contributor

coderabbitai bot commented Jul 29, 2024

Walkthrough

The recent changes to the JSEditorForm component in the Form.tsx file enhance its visual layout by modifying a <div> element's class. The update ensures the <div> fills the full width of its container, potentially improving responsiveness and alignment in the user interface, especially in split view scenarios. This cosmetic adjustment aims to address usability concerns related to code visibility in the IDE.

Changes

Files Change Summary
app/client/src/pages/Editor/JSEditor/Form.tsx Updated class from "flex flex-1" to "flex flex-1 w-full" for improved layout responsiveness.

Assessment against linked issues

Objective Addressed Explanation
Enable horizontal scrolling in split view ( #35240 ) The change does not address scrolling functionality.

🎉 In the realm of code, a change does unfold,
A wider layout for the brave and bold.
With classes adjusted, layout now grand,
Responsive design, just as we planned!
So scroll with ease, let your code be seen,
In the split view's embrace, a developer's dream! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working Community Reported issues reported by community members IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE Production labels Jul 29, 2024
@albinAppsmith albinAppsmith added the ok-to-test Required label for CI label Jul 29, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 58f0c0d and ce0fcc9.

Files selected for processing (1)
  • app/client/src/pages/Editor/JSEditor/Form.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/pages/Editor/JSEditor/Form.tsx

@albinAppsmith albinAppsmith merged commit 7146bdc into release Jul 29, 2024
84 checks passed
@albinAppsmith albinAppsmith deleted the js-object-line-oveflow branch July 29, 2024 15:19
@github-actions github-actions bot added QA Needs QA attention QA Pod Issues under the QA Pod labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community Reported issues reported by community members IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot horizontally scroll in IDE when the split view
3 participants