Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View mode canvas margin #35619

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: View mode canvas margin #35619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/src/pages/AppViewer/AppPage/AppPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function AppPage(props: AppPageProps) {
}, [isAnvilLayout, canvasWidth]);

const pageViewWrapperRef = useRef<HTMLDivElement>(null);
useCanvasWidthAutoResize({ ref: pageViewWrapperRef, sidebarWidth });
useCanvasWidthAutoResize({ ref: pageViewWrapperRef });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove sidebarWidth from useCanvasWidthAutoResize as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left it incase we need it in the future. It is a optional argument anyways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced sidebarWidth param solely for AppPage component, but since it was a mistake, it appears that there is no reason to keep it, moreover its intent/origin may be confusing to developers.


useEffect(() => {
AnalyticsUtil.logEvent("PAGE_LOAD", {
Expand Down
Loading