chore: Fix table columns when hidden are not greyed out in preview mode

[jsartisan]

Fixes #34852

Grey out the header cells and row cells when the column is set invisible.

Before:

After:

/ok-to-test tags="@tag.Widget"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10422331593
Commit: 045a3e7
Cypress dashboard.
Tags: @tag.Widget
Spec:

---

Fri, 16 Aug 2024 16:28:06 UTC

Summary by CodeRabbit

• New Features
  • Enhanced the visual feedback for users interacting with the WDSTableWidget by improving opacity styles for disabled table headers and cells.

[coderabbitai]

Walkthrough

The recent changes enhance the styling of the WDSTableWidget component by adding CSS rules that improve the user experience in preview mode. Specifically, these updates ensure that table headers and cells that are hidden are visually represented with reduced opacity, indicating their inactive status. This addresses confusion arising from hidden columns appearing without visual cues in the preview.

Changes

File	Change Summary
app/client/src/widgets/wds/WDSTableWidget/component/styles.module.css	Added CSS rules for thead and cell elements with aria-hidden to adjust opacity, improving visibility of inactive elements.

Assessment against linked issues

Objective	Addressed	Explanation
Table columns when hidden are not greyed out in preview mode (#34852)	✅
Visual feedback for hidden columns in preview mode (#34852)	✅

Poem

In the table's dance, a change so bright,
Hidden columns now fade, a clearer sight.
With CSS magic, confusion departs,
Visual cues guide our curious hearts.
Let's celebrate this style, a friendly embrace,
In the world of widgets, a touch of grace! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66e535d and 045a3e7.

Files selected for processing (1)

• app/client/src/widgets/wds/WDSTableWidget/component/styles.module.css (2 hunks)

Additional comments not posted (2)

app/client/src/widgets/wds/WDSTableWidget/component/styles.module.css (2)

81-83: Great job on enhancing visual feedback for hidden column headers!

The addition of setting opacity for column headers with the aria-hidden attribute effectively communicates their hidden status. This aligns well with the PR's objective to improve user experience by visually indicating inactive elements.

---

158-160: Excellent work on ensuring consistency for hidden table cells!

Applying opacity to cells with the aria-hidden attribute provides a clear visual cue for their inactive status, enhancing user understanding of hidden columns in preview mode. This change is well-aligned with the PR's goals.