Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Video2 spec flaky fix #36166

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: Video2 spec flaky fix #36166

merged 2 commits into from
Sep 9, 2024

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Sep 6, 2024

Description

RCA: We are using youtube url for Verify Basic Functionality of Video Widget - muted. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case.

Solution: Deleted this test as it can be part of manual testing.

Fixes #36164

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10766784105
Commit: 11d8d95
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Mon, 09 Sep 2024 05:41:15 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes

    • Removed a test case for the muted functionality of the Video Widget, streamlining the test suite.
  • Chores

    • Updated the test path in the limited-tests file to prioritize video widget testing over template testing.

Copy link
Contributor

coderabbitai bot commented Sep 6, 2024

Walkthrough

The changes involve modifications to the Cypress test suite for the Video Widget, specifically the removal of a test case that verified the widget's functionality when muted. This led to a renumbering of the subsequent test cases. Additionally, the path for a test specification was updated in the limited-tests.txt file, shifting focus from template testing to video widget testing.

Changes

Files Change Summary
app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts Removed the test case for the Video Widget's muted functionality and renumbered subsequent tests.
app/client/cypress/limited-tests.txt Updated the test path from template testing to video widget testing.

Sequence Diagram(s)

(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.)

Poem

In the land of tests, a change took flight,
A muted case vanished, no longer in sight.
The numbers shifted, a tidy new row,
Video widget's focus now takes center show.
With paths now aligned, the tests march ahead,
In the realm of code, new journeys are spread! 🎥✨


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Sep 6, 2024
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=20

Copy link

github-actions bot commented Sep 6, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 58b07dd and 6cd75c9.

Files selected for processing (2)
  • app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts (5 hunks)
  • app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (2)
  • app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts
  • app/client/cypress/limited-tests.txt

Copy link

github-actions bot commented Sep 6, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10740462665.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 120 Total Passed: 120 Total Failed: 0 Total Skipped: 0 *****************************

@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Sep 6, 2024
@sagar-qa007 sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 7, 2024
@sagar-qa007 sagar-qa007 closed this Sep 9, 2024
@sagar-qa007 sagar-qa007 reopened this Sep 9, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
RCA: We are using youtube url for `Verify Basic Functionality of Video
Widget - muted`. Which leads to flakiness. Also this case needs a human
intervention to fulfilled the actual user case.

Solution: Deleted this test as it can be part of manual testing.

Fixes #`36164`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10766784105>
> Commit: 11d8d95
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10766784105&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 09 Sep 2024 05:41:15 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Removed a test case for the muted functionality of the Video Widget,
streamlining the test suite.
  
- **Chores**
- Updated the test path in the limited-tests file to prioritize video
widget testing over template testing.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants