-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Video2 spec flaky fix #36166
fix: Video2 spec flaky fix #36166
Conversation
WalkthroughThe changes involve modifications to the Cypress test suite for the Video Widget, specifically the removal of a test case that verified the widget's functionality when muted. This led to a renumbering of the subsequent test cases. Additionally, the path for a test specification was updated in the Changes
Sequence Diagram(s)(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.) Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/ci-test-limit-count run_count=20 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10740462665. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts (5 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (2)
- app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts
- app/client/cypress/limited-tests.txt
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10740462665.
|
## Description RCA: We are using youtube url for `Verify Basic Functionality of Video Widget - muted`. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case. Solution: Deleted this test as it can be part of manual testing. Fixes #`36164` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10766784105> > Commit: 11d8d95 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10766784105&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 09 Sep 2024 05:41:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed a test case for the muted functionality of the Video Widget, streamlining the test suite. - **Chores** - Updated the test path in the limited-tests file to prioritize video widget testing over template testing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
RCA: We are using youtube url for
Verify Basic Functionality of Video Widget - muted
. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case.Solution: Deleted this test as it can be part of manual testing.
Fixes #
36164
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10766784105
Commit: 11d8d95
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Mon, 09 Sep 2024 05:41:15 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Bug Fixes
Chores