Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anthropic plugin config updated with better file structure #36223

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Sep 10, 2024

Description

Reverting the Anthropic file structure to the previous structure. This also means the UI will get updated to the new shared design.

Fixes #35485

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10806310053
Commit: b7a7184
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
  2. cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
List of identified flaky tests.
Wed, 11 Sep 2024 08:07:04 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced a new chat interface configuration for AI-driven interactions, enhancing user engagement with dynamic input fields.
    • Added a new configuration for vision capabilities, allowing users to interact with vision-based AI models through a structured interface.
  • Changes

    • Simplified the editor's configuration by renaming sections and removing unnecessary controls, streamlining the user experience.
    • Updated file management structure to enhance modularity with external references to configuration files.

Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Walkthrough

The changes introduced in this pull request involve the addition of new JSON configuration files for AI-driven chat and vision functionalities within the Anthropic plugin. The chat configuration enhances user interaction by providing structured input fields, while the vision configuration establishes controls for visual input processing. Additionally, the existing root configuration has been simplified, focusing on modularity by referencing the new files.

Changes

Files Change Summary
app/server/appsmith-plugins/anthropicPlugin/src/main/resources/editor/chat.json Added a configuration schema for AI chat functionality, defining input fields and properties for user interaction.
app/server/appsmith-plugins/anthropicPlugin/src/main/resources/editor/root.json Renamed identifier from "SECTION-ONE" to "SELECTOR" and added a "files" array referencing "chat.json" and "vision.json". Removed multiple sections related to "CHAT" and "VISION".
app/server/appsmith-plugins/anthropicPlugin/src/main/resources/editor/vision.json Added a configuration schema for vision functionalities, detailing input controls for model selection, token limits, prompts, messages, and temperature adjustments.

Assessment against linked issues

Objective Addressed Explanation
Better grouping of fields (#[35485])
Better alignments of the fields (#[35485])
Update the Anthropic plugin form Unclear if all aspects of the form were updated as intended.

Poem

In the realm of code, new zones arise,
With chat and vision, the user complies.
Fields now grouped, aligned with grace,
A dance of inputs in a structured space.
Anthropic's magic, a plugin's delight,
Guiding our queries, both day and night. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo Bug Something isn't working labels Sep 10, 2024
@albinAppsmith albinAppsmith added the ok-to-test Required label for CI label Sep 11, 2024
"controlType": "SINGLE_COLUMN_ZONE",
"children": [
{
"label": "Messages",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the previous field and this field be combined? Same comment in the vision file.

ankitakinger
ankitakinger previously approved these changes Sep 11, 2024
Copy link
Contributor

@ankitakinger ankitakinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetunandu hetunandu merged commit cd7b66f into release Sep 11, 2024
79 of 82 checks passed
@hetunandu hetunandu deleted the anthropic-file-structure branch September 11, 2024 10:07
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
…mithorg#36223)

## Description

Reverting the Anthropic file structure to the previous structure. This
also means the UI will get updated to the new shared design.


Fixes appsmithorg#35485

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10806310053>
> Commit: b7a7184
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10806310053&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Wed, 11 Sep 2024 08:07:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a new chat interface configuration for AI-driven
interactions, enhancing user engagement with dynamic input fields.
- Added a new configuration for vision capabilities, allowing users to
interact with vision-based AI models through a structured interface.

- **Changes**
- Simplified the editor's configuration by renaming sections and
removing unnecessary controls, streamlining the user experience.
- Updated file management structure to enhance modularity with external
references to configuration files.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product ok-to-test Required label for CI Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add Zone & Section to Anthropic plugin form
3 participants