fix: Default invalid sheet method value in Gsheet datasource

[rishabhrathod01]

Description

The default value for gsheet method didn't match with the available method in the list and hence showed unexpected result. This change updates the default value to match the available option.

Fixes #36263

Automation

/test gsheet

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10824475544
Commit: 13c28b2
Cypress dashboard.
Tags: @tag.GSheet
Spec:

---

Thu, 12 Sep 2024 05:17:08 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Enhanced security for the Google Sheets plugin by restricting access permissions.
  • Updated the plugin to allow access only to files created or opened by the application.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the initialValue property in the form.json file for the Google Sheets plugin. The authorization scope has been changed from broader access, which included both spreadsheets and drive files, to a more restricted scope that allows access only to files created or opened by the application. This change aims to enhance security by limiting the permissions granted to the plugin.

Changes

File	Change Summary
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/form.json	Modified initialValue from "https://www.googleapis.com/auth/spreadsheets,https://www.googleapis.com/auth/drive" to "https://www.googleapis.com/auth/drive.file"

Assessment against linked issues

Objective	Addressed	Explanation
Block the All Google Sheets option in the dropdown (#36263)	✅
Ensure that only Selected Google Sheets are available (#36263)	✅

Possibly related PRs

• fix: Remove Gsheets unauth method #36125: This PR involves modifications to the form.json file for the Google Sheets plugin, specifically related to authorization scopes, which aligns with the changes made in the main PR.

Suggested labels

Critical, Production, ok-to-test

Poem

In the realm of sheets, a change so bright,
Permissions trimmed, now just right.
No more all-access, just what we need,
A safer path for every deed.
With every scope, we guard our way,
Securely we work, come what may! 🌟

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4189a70 and 13c28b2.

Files selected for processing (1)

• app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/form.json (1 hunks)

Additional comments not posted (1)

app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/form.json (1)

43-43: Excellent work on enhancing security! The change looks good to me.

Narrowing down the scope from https://www.googleapis.com/auth/spreadsheets,https://www.googleapis.com/auth/drive to https://www.googleapis.com/auth/drive.file is a great way to implement the principle of least privilege.

This will ensure that the plugin only has access to files created or opened by the application, instead of all spreadsheets and drive files. By limiting the permissions to the minimum required, we can significantly reduce the potential impact in case of any security vulnerabilities in the plugin.

The change aligns perfectly with the PR objective of removing the "All Google Sheets" option and restricting access to only selected sheets. Kudos on this security enhancement!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rishabhrathod01]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10824491201.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36264.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-36264.dp.appsmith.com

[github-actions]

Failed server tests

• com.appsmith.server.solutions.ce.ActionExecutionSolutionCETest#testActionExecuteSecondaryStaleConnection