chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies #36266

mohanarpit · 2024-09-12T05:18:42Z

Description

This PR updates Spring and it's associated dependencies to resolve vulnerable dependencies as flagged by Dependabot and Docker Scout.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10938821689
Commit: 68a6ae2
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/AbortAction_Spec.ts
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts

List of identified flaky tests.

Thu, 19 Sep 2024 11:32:09 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Updated the Spring Boot parent dependency to version 3.3.3, enhancing application performance and stability.
Bug Fixes
- Removed specific version declarations for spring-boot-starter-webflux across multiple plugins, streamlining dependency management and reducing potential inconsistencies.
Chores
- Removed the mockito-inline dependency, which may impact testing capabilities.

coderabbitai · 2024-09-12T05:18:51Z

Walkthrough

The pull request involves updates to the pom.xml files across various modules in the Appsmith project. Key changes include the removal of explicit version specifications for the spring-boot-starter-webflux dependency in multiple plugins, which allows for more flexible dependency management. Additionally, the main server's pom.xml has been updated to use a newer version of Spring Boot and testcontainers, while also removing certain version properties and dependencies.

Changes

File Path	Change Summary
`app/server/appsmith-plugins/*/pom.xml`	Removed `<version>${spring-boot.version}</version>` for `spring-boot-starter-webflux` in all plugins.
`app/server/appsmith-server/pom.xml`	Removed `mockito-inline`, added `commons-codec` version `1.17.1`, and removed Spring Boot version specification.
`app/server/pom.xml`	Updated Spring Boot parent version from `3.0.9` to `3.3.3` and removed `<spring-boot.version>`.

Possibly related PRs

feat: Action redesign: Updating the config for MongoDB plugin to use sections and zones format #36098: The changes in the main PR involve updates to the pom.xml file, which is also modified in this PR related to the MongoDB plugin, indicating a connection in dependency management.
fix: logger-not-working-in-plugins #36231: This PR modifies the pom.xml file to enhance logging capabilities, which is relevant to the changes in the main PR that also involve updates to the pom.xml file.
chore: Upgrade vulnerable express dependency #36265: The main PR updates dependencies in the pom.xml, and this PR also focuses on upgrading a vulnerable dependency in a related package.json, showing a common theme of dependency management.

Suggested labels

Bug, High

Poem

In the realm of code where plugins unite,
Versions were tangled, now they shine bright.
Spring Boot's new version, a fresh start,
Dependencies dance, each playing their part.
With codecs added and mocks laid to rest,
In Appsmith's domain, we strive for the best! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

app/server/appsmith-server/pom.xml

app/server/pom.xml

nidhi-nair · 2024-09-17T09:05:49Z

app/server/appsmith-plugins/anthropicPlugin/pom.xml

@@ -89,7 +89,6 @@
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-webflux</artifactId>


Interesting that we're asking for a test dependency here, we should be able to shade this from interfaces directly. Did you get any clues as to why the version was explicitly mentioned here before?

Good point. I don't remember why we did this.

github-actions · 2024-09-17T09:46:24Z

Failed server tests

com.appsmith.testcaching.test.TestCachingMethods#

…h into chore/spring-upgrade

mohanarpit added 2 commits September 12, 2024 10:47

chore: Upgrading spring dependencies

d18e600

chore: Upgrading test-containers version in pom.xml

38512ef

mohanarpit requested a review from sharat87 as a code owner September 12, 2024 05:18

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 12, 2024

mohanarpit added the ok-to-test Required label for CI label Sep 12, 2024

nidhi-nair reviewed Sep 17, 2024

View reviewed changes

app/server/appsmith-server/pom.xml Show resolved Hide resolved

nidhi-nair reviewed Sep 17, 2024

View reviewed changes

app/server/pom.xml Show resolved Hide resolved

nidhi-nair reviewed Sep 17, 2024

View reviewed changes

Switched listCollectionNames mock to a publisher mock

ab36acf

Remove hard-coded logback veersion

330cbdc

nidhi-nair added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 17, 2024

nidhi-nair added 3 commits September 17, 2024 17:20

Merge branch 'release' into chore/spring-upgrade

d350563

Bunch of dependencies that needed to upgrade as well

d9ab5db

Merge branch 'chore/spring-upgrade' of github.com:appsmithorg/appsmit…

68a6ae2

…h into chore/spring-upgrade

nidhi-nair added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 18, 2024

nidhi-nair self-requested a review September 18, 2024 06:07

nidhi-nair added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies #36266

chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies #36266

mohanarpit commented Sep 12, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

nidhi-nair Sep 17, 2024

mohanarpit Sep 17, 2024

github-actions bot commented Sep 17, 2024

chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies #36266

Are you sure you want to change the base?

chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies #36266

Conversation

mohanarpit commented Sep 12, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Sep 12, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

nidhi-nair Sep 17, 2024

Choose a reason for hiding this comment

mohanarpit Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024

Failed server tests

mohanarpit commented Sep 12, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 12, 2024 •

edited

Loading