chore: Map Chart Spec #36343

jsartisan · 2024-09-16T10:34:13Z

Summary by CodeRabbit

New Features
- Enhanced accuracy in Map Chart Widget tests with updated element selection methods.
- Included new test case for immediate validation of title changes in the Map Chart settings.
- Updated data point interactions in tests to reflect current data context.
- Added mapChartWidget locator for improved test functionality.
Bug Fixes
- Streamlined visibility tests for the Map Chart Widget, removing unnecessary assertions.
Chores
- Updated the limited tests configuration to include the new Map Chart tests while excluding the Fork Template test.

Warning

Tests have not run on the HEAD 0a1afd3 yet

Tue, 17 Sep 2024 07:24:36 UTC

jsartisan · 2024-09-16T10:34:21Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-16T10:34:43Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10882087903.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36343.
recreate: .

github-actions · 2024-09-16T10:38:45Z

Deploy-Preview-URL: https://ce-36343.dp.appsmith.com

coderabbitai · 2024-09-16T12:57:05Z

Walkthrough

The changes in this pull request enhance the Map Chart Widget tests within the Cypress framework. Key updates include modifications to element selection methods, improvements in assertions for title updates and widget visibility, and adjustments to the data points used in interactions. Additionally, the limited-tests.txt file has been revised to exclude the Fork_Template_spec.js test while including the new MapChart_Spec.ts, reflecting a shift in testing priorities.

Changes

File Path	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts`	Updated element selection method, refined title assertion, streamlined visibility tests, and modified data points and expected messages.
`app/client/cypress/limited-tests.txt`	Commented out `Fork_Template_spec.js` and added `MapChart_Spec.ts` to the limited tests list.
`app/client/cypress/locators/publishWidgetspage.json`	Corrected JSON formatting and added `mapChartWidget` locator.

Possibly related PRs

chore: fix select1 spec #36228: The changes in this PR involve modifications to the Select1_spec.ts file, which is related to the MapChart_Spec.ts file in the main PR as both are part of the Cypress end-to-end tests for widgets.
feat: Allow table search to include label and value for tables with select column type #36061: This PR also involves Cypress tests for a table component, which shares a similar testing framework and methodology with the Map Chart Widget tests in the main PR.
fix: Fixed Bug29566 spec with list widget #36260: This PR addresses a bug in a list widget test, which, like the Map Chart Widget tests, is part of the Cypress testing suite.
test: fix DataSourceScheme #36339: This PR focuses on enhancing the reliability of the DataSourceScheme test, which is part of the broader testing framework that includes the Map Chart Widget tests.

Suggested labels

Task, Widgets Product, ok-to-test

🎉 In the land of tests, we make our mark,
With Map Chart changes, we ignite a spark.
From titles that shine to data points anew,
Our Cypress tests now dance, all fresh and true.
Excluding the past, we embrace the bright,
In the world of testing, we soar to new heights! 🌟

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6922c69 and 0a1afd3.

Files selected for processing (1)

app/client/cypress/locators/publishWidgetspage.json (3 hunks)

Files skipped from review due to trivial changes (1)

app/client/cypress/locators/publishWidgetspage.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jsartisan · 2024-09-16T12:58:06Z

/ci-test-limit-count run_count=1

github-actions · 2024-09-16T12:58:39Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10884305172.
Cypress dashboard
PR: #36343.

sagar-qa007 · 2024-09-16T12:58:03Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts


 describe(
  "Map Chart Widget Functionality",
  { tags: ["@tag.Widget", "@tag.Maps", "@tag.Visual"] },
  function () {
-    it("1. Drag and drop a Map Chart widget and verify", function () {
+    it.only("1. Drag and drop a Map Chart widget and verify", function () {


Please remove only.

sagar-qa007 · 2024-09-16T12:58:27Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts

@@ -14,13 +14,13 @@ import EditorNavigation, {

 const _mapChartCaption = "text:last-child";
 const _mapChartPlot = (text: string) =>
-  "//text()[contains(., '" + text + "')]/..";
+  `//*[name()='svg']//*[name()='text' and contains(text(), '${text}')]`;


Can we please use data-testid or css locator here?

Nope. The rendered component is coming from 3rd library. Not much control over it.

Let's optimise this then. Discussing with you offline.

jsartisan · 2024-09-16T13:01:07Z

/ci-test-limit-count run_count=1

github-actions · 2024-09-16T13:01:42Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10884360710.
Cypress dashboard
PR: #36343.

github-actions · 2024-09-16T13:18:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10884305172.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 1 Total Passed: 0 Total Failed: 1 Total Skipped: 0 *****************************

jsartisan · 2024-09-16T13:19:59Z

/ci-test-limit-count run_count=15

github-actions · 2024-09-16T13:20:32Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10884698717.
Cypress dashboard
PR: #36343.

github-actions · 2024-09-16T13:21:09Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10884360710.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 1 Total Passed: 0 Total Failed: 1 Total Skipped: 0 *****************************

github-actions · 2024-09-16T14:01:54Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10884698717.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 15 Total Passed: 0 Total Failed: 15 Total Skipped: 0 *****************************

jsartisan · 2024-09-17T05:42:05Z

/ci-test-limit-count run_count=15

github-actions · 2024-09-17T05:42:37Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10897233252.
Cypress dashboard
PR: #36343.

sagar-qa007 · 2024-09-17T05:43:31Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts

@@ -14,13 +14,13 @@ import EditorNavigation, {

 const _mapChartCaption = "text:last-child";
 const _mapChartPlot = (text: string) =>
-  "//text()[contains(., '" + text + "')]/..";
+  `//*[name()='svg']//*[name()='text' and contains(text(), '${text}')]`;


Let's optimise this then. Discussing with you offline.

jsartisan · 2024-09-17T07:13:17Z

/ci-test-limit-count run_count=1

github-actions · 2024-09-17T07:13:47Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10898281289.
Cypress dashboard
PR: #36343.

jsartisan · 2024-09-17T07:30:05Z

/ci-test-limit-count run_count=1

github-actions · 2024-09-17T07:30:40Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10898514979.
Cypress dashboard
PR: #36343.

Trigger Build

bda8441

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 16, 2024

update mapchart

487239b

jsartisan requested review from ApekshaBhosale and sagar-qa007 as code owners September 16, 2024 12:56

add test to limited list

ed9525f

sagar-qa007 requested changes Sep 16, 2024

View reviewed changes

remove only

fff28ea

remove genreated snaps

d986178

sagar-qa007 requested changes Sep 17, 2024

View reviewed changes

fix prettier error

0d3b331

update selector

6922c69

update selector

0a1afd3

jsartisan closed this Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Map Chart Spec #36343

chore: Map Chart Spec #36343

jsartisan commented Sep 16, 2024 •

edited by coderabbitai bot

Loading

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

coderabbitai bot commented Sep 16, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

sagar-qa007 Sep 16, 2024

jsartisan Sep 16, 2024

sagar-qa007 Sep 16, 2024

jsartisan Sep 16, 2024

sagar-qa007 Sep 17, 2024

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 Sep 17, 2024

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

chore: Map Chart Spec #36343

chore: Map Chart Spec #36343

Conversation

jsartisan commented Sep 16, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

coderabbitai bot commented Sep 16, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

sagar-qa007 Sep 16, 2024

Choose a reason for hiding this comment

jsartisan Sep 16, 2024

Choose a reason for hiding this comment

sagar-qa007 Sep 16, 2024

Choose a reason for hiding this comment

jsartisan Sep 16, 2024

Choose a reason for hiding this comment

sagar-qa007 Sep 17, 2024

Choose a reason for hiding this comment

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jsartisan commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 Sep 17, 2024

Choose a reason for hiding this comment

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

jsartisan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

jsartisan commented Sep 16, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 16, 2024 •

edited

Loading