-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test:Fix canvas context prop01 #36391
Conversation
WalkthroughThe changes in this pull request involve updates to Cypress test files, enhancing the logic for verifying property pane sections. The tests now utilize the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/ci-test-limit-count run_count=25 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10919392761. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10919392761.
|
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159 RCA: The property section related validations were not working Solution: Enhanced verification of property pane section visibility using accessibility attributes. Introduced new UI interaction properties for managing collapsible sections. /ok-to-test tags="@tag.IDE" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10923368993> > Commit: c996a38 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10923368993&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 18 Sep 2024 14:10:07 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved test logic for verifying the state of property pane sections, enhancing accessibility compliance. - Updated limited tests to include new test specifications for the property pane. - **Bug Fixes** - Enhanced robustness of tests by refining visibility state checks using ARIA attributes. - **Chores** - Expanded locator capabilities in the testing framework to support new UI components related to collapsible sections. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159
RCA:
The property section related validations were not working
Solution:
Enhanced verification of property pane section visibility using accessibility attributes.
Introduced new UI interaction properties for managing collapsible sections.
/ok-to-test tags="@tag.IDE"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10923368993
Commit: c996a38
Cypress dashboard.
Tags:
@tag.IDE
Spec:
Wed, 18 Sep 2024 14:10:07 UTC
Summary by CodeRabbit
New Features
Bug Fixes
Chores