Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:Fix canvas context prop01 #36391

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

NandanAnantharamu
Copy link
Collaborator

@NandanAnantharamu NandanAnantharamu commented Sep 18, 2024

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159

RCA:
The property section related validations were not working

Solution:

Enhanced verification of property pane section visibility using accessibility attributes.
Introduced new UI interaction properties for managing collapsible sections.

/ok-to-test tags="@tag.IDE"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10923368993
Commit: c996a38
Cypress dashboard.
Tags: @tag.IDE
Spec:


Wed, 18 Sep 2024 14:10:07 UTC

Summary by CodeRabbit

  • New Features

    • Improved test logic for verifying the state of property pane sections, enhancing accessibility compliance.
    • Updated limited tests to include new test specifications for the property pane.
  • Bug Fixes

    • Enhanced robustness of tests by refining visibility state checks using ARIA attributes.
  • Chores

    • Expanded locator capabilities in the testing framework to support new UI components related to collapsible sections.

Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes in this pull request involve updates to Cypress test files, enhancing the logic for verifying property pane sections. The tests now utilize the aria-hidden attribute for state verification instead of relying on DOM structure checks. Additionally, the list of limited tests has been modified to include a new test file. Two new properties have also been added to the CommonLocators class to improve element targeting for collapsible sections.

Changes

File Path Change Summary
app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js Updated logic for verifying property pane sections using aria-hidden instead of DOM checks.
app/client/cypress/limited-tests.txt Replaced Fork_Template_spec.js with Canvas_Context_Property_Pane_1_spec.js in limited tests.
app/client/cypress/support/Objects/CommonLocators.ts Added _propertyCollapseBody and _propertyCollapse properties to enhance UI component targeting.

Possibly related PRs

Suggested labels

ok-to-test, Test, IDE Product, IDE Navigation

Suggested reviewers

  • ApekshaBhosale
  • sagar-qa007
  • NandanAnantharamu

Poem

In tests where icons used to reign,
Now aria-hidden holds the gain.
With locators fresh, they seek and find,
Enhancing checks, both clear and kind.
A canvas bright, a property pane,
In Cypress tests, we’ll dance again! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NandanAnantharamu
Copy link
Collaborator Author

/ci-test-limit-count run_count=25

Copy link

@NandanAnantharamu NandanAnantharamu added the ok-to-test Required label for CI label Sep 18, 2024
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10919392761.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 225 Total Passed: 225 Total Failed: 0 Total Skipped: 0 *****************************

@NandanAnantharamu NandanAnantharamu changed the title Test/fix context prop01 Test : Fix canvas context prop01 Sep 18, 2024
@NandanAnantharamu NandanAnantharamu changed the title Test : Fix canvas context prop01 test:Fix canvas context prop01 Sep 19, 2024
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Sep 19, 2024
@NandanAnantharamu NandanAnantharamu merged commit 006dbfd into release Sep 19, 2024
44 checks passed
@NandanAnantharamu NandanAnantharamu deleted the test/fixContextProp01 branch September 19, 2024 06:09
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159

RCA:
The property section related validations were not working

Solution:

Enhanced verification of property pane section visibility using
accessibility attributes.
Introduced new UI interaction properties for managing collapsible
sections.

/ok-to-test tags="@tag.IDE"

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10923368993>
> Commit: c996a38
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10923368993&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 18 Sep 2024 14:10:07 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved test logic for verifying the state of property pane sections,
enhancing accessibility compliance.
- Updated limited tests to include new test specifications for the
property pane.

- **Bug Fixes**
- Enhanced robustness of tests by refining visibility state checks using
ARIA attributes.

- **Chores**
- Expanded locator capabilities in the testing framework to support new
UI components related to collapsible sections.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
@coderabbitai coderabbitai bot mentioned this pull request Sep 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants