Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add server artifacts for pg and mongodb for github release workflow #36516

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Sep 24, 2024

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced GitHub Actions workflow to conditionally prepare server artifacts based on the presence of a specific script.
  • Chores

    • Added a new job step in the GitHub Actions workflow for improved artifact management.

@abhvsn abhvsn requested a review from sharat87 as a code owner September 24, 2024 13:38
Copy link
Contributor

coderabbitai bot commented Sep 24, 2024

Walkthrough

A new job step has been added to the GitHub Actions workflow in .github/workflows/github-release.yml. This step, named "Place server artifacts-es," conditionally executes a shell script called prepare_server_artifacts.sh if it exists in the scripts directory. The addition is positioned after the generation of an info JSON file and before the DockerHub login step, enhancing the workflow's functionality.

Changes

File Change Summary
.github/workflows/github-release.yml Added a new job step "Place server artifacts-es" to conditionally execute prepare_server_artifacts.sh if it exists.

Possibly related PRs

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

  • sharat87
  • riteshkew
  • mohanarpit

In the land of code where workflows dwell,
A new step was added, oh, what a spell!
Artifacts prepared with a script in tow,
Enhancing the process, watch it flow!
With DockerHub waiting, the stage is set,
A seamless release, you can bet! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abhvsn abhvsn changed the title chore: Add server artifacts placer for github release workflow chore: Add server artifacts for pg and mongodb for github release workflow Sep 24, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 24, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
.github/workflows/github-release.yml (1)

250-254: Class, let's examine this new step in our workflow!

I'm pleased to see you've added a new step to place server artifacts. This is a good addition to our release process. However, let's consider a few improvements to make it even better:

  1. Add some error handling to catch any issues that might occur during script execution.
  2. Include logging to help us track the progress and success of the script.
  3. Consider adding a comment explaining the purpose of this step for future reference.

Here's an example of how you might enhance this step:

- name: Place server artifacts-es
  run: |
    if [[ -f scripts/prepare_server_artifacts.sh ]]; then
      echo "Executing prepare_server_artifacts.sh script..."
      if ! scripts/prepare_server_artifacts.sh; then
        echo "Error: Failed to prepare server artifacts"
        exit 1
      fi
      echo "Server artifacts prepared successfully"
    else
      echo "Warning: prepare_server_artifacts.sh not found, skipping this step"
    fi

Remember, clear communication in our code helps the whole class understand and maintain it better!

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 368fdac and f2a91a7.

Files selected for processing (1)
  • .github/workflows/github-release.yml (1 hunks)

@abhvsn abhvsn merged commit 4ea2803 into release Sep 24, 2024
18 checks passed
@abhvsn abhvsn deleted the chore/add-server-artifacts-for-tagging-script branch September 24, 2024 13:50
abhvsn added a commit that referenced this pull request Sep 24, 2024
…kflow (#36516)

## Description
> [!TIP]
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced GitHub Actions workflow to conditionally prepare server
artifacts based on the presence of a specific script.

- **Chores**
- Added a new job step in the GitHub Actions workflow for improved
artifact management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit 4ea2803)
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
…kflow (appsmithorg#36516)

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced GitHub Actions workflow to conditionally prepare server
artifacts based on the presence of a specific script.

- **Chores**
- Added a new job step in the GitHub Actions workflow for improved
artifact management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Nov 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants