Rtl #36765
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ else | |
| echo "Skipping server side check..." | ||
| fi | ||
|
|
||
| if [ "$is_client_change" -ge 1 ]; then | ||
| echo "Running client check ..." | ||
| npx lint-staged --cwd app/client | ||
| else | ||
| echo "Skipping client side check..." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| ], | ||
| "scripts": { | ||
| "analyze": "yarn cra-bundle-analyzer", | ||
| "start": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT REACT_APP_CLIENT_LOG_LEVEL=debug HOST=0.0.0.0 craco --max_old_space_size=7168 start", | ||
|
There was a problem hiding this comment. 💡 Codebase verification Attention to Configuration Consistency! It appears that while the
Please ensure all instances of the old 🔗 Analysis chainClass, let's examine the changes in our development environment setup! Now, pay attention to the modifications in our
However, remember that with great power comes great responsibility. Make sure your development machine can handle this increased memory allocation. Any questions about these changes? Let's run a quick check to ensure our changes don't conflict with any other scripts: Great effort so far! Let's ensure we're searching in the right places. It looks like the previous attempt couldn't find the Here's a script to help us with that: Let's run this script to verify that the changes we've made are consistent across all relevant Great job sticking with this! Let's dive deeper into our It seems our previous search didn't find the Here's a new script to check the Let's execute this to confirm that our changes are consistent within the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if the new HOST and max_old_space_size values are used consistently across all scripts
# Test: Search for any other occurrences of dev.appsmith.com or the old max_old_space_size value
rg 'dev\.appsmith\.com|--max_old_space_size=4096' package.json
Length of output: 117 Script: #!/bin/bash
# Description: Locate all package.json files and search for specific patterns to ensure consistency.
# Find all package.json files and search for occurrences of 'dev.appsmith.com' or '--max_old_space_size=4096'
fd 'package\.json' . -x grep -H 'dev\.appsmith\.com|--max_old_space_size=4096' {}
Length of output: 85 Script: #!/bin/bash
# Description: Search for 'dev.appsmith.com' and '--max_old_space_size=4096' in app/client/package.json
rg 'dev\.appsmith\.com|--max_old_space_size=4096' app/client/package.json
Length of output: 233 |
||
| "build": "./build.sh", | ||
| "build-airgap": "node download-assets.js && ./build.sh", | ||
| "build-local": "craco --max-old-space-size=4096 build --config craco.build.config.js", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ import { | |
| fetchFeatureFlagsInit, | ||
| fetchProductAlertInit, | ||
| } from "actions/userActions"; | ||
| import { validateResponse } from "./ErrorSagas"; | ||
| import type { ApiResponse } from "api/ApiResponses"; | ||
| import type { ProductAlert } from "reducers/uiReducers/usersReducer"; | ||
| import type { FeatureFlags } from "ee/entities/FeatureFlag"; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be careful with our secrets, students!
I noticed that we're echoing the DockerHub username, which is stored as a secret. While it's important to have visibility into our environment, we must be cautious about potentially exposing sensitive information in our logs.
Consider removing or masking the DockerHub username output:
This way, we maintain visibility without risking the exposure of our DockerHub credentials. Remember, in the world of DevOps, secrecy is golden!
📝 Committable suggestion