Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: heartbeat code removed #36837

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: heartbeat code removed #36837

merged 1 commit into from
Oct 15, 2024

Conversation

ApekshaBhosale
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale commented Oct 11, 2024

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11339670501
Commit: cc4ac6d
Cypress dashboard.
Tags: @tag.All
Spec:


Tue, 15 Oct 2024 07:53:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Integrated New Relic for enhanced telemetry tracking.
  • Bug Fixes

    • Removed the Heartbeat component to streamline application performance and rendering logic.
  • Chores

    • Cleaned up unnecessary variables related to component rendering.

Copy link
Contributor

coderabbitai bot commented Oct 11, 2024

Walkthrough

This pull request involves the deletion of the Heartbeat.tsx file, which contained a React component responsible for sending periodic heartbeat signals. Additionally, the index.tsx file was modified to integrate New Relic for telemetry, removing the cloudHosting and isProduction variables that previously controlled the rendering of the Heartbeat component. As a result, the application’s rendering logic has been simplified while enhancing its telemetry capabilities.

Changes

File Change Summary
app/client/src/Heartbeat.tsx Component removed: Heartbeat responsible for sending heartbeat signals.
app/client/src/index.tsx Added New Relic configuration; removed cloudHosting and isProduction variables; simplified rendering logic.

Possibly related PRs

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

  • sharat87
  • AnaghHegde

In the code's heart, a signal did play,
Sending its whispers, day after day.
But now it has vanished, like mist in the sun,
New Relic's here, and the changes are done!
A simpler path, with telemetry bright,
Our app shines anew, oh what a delight! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e03522f and cc4ac6d.

📒 Files selected for processing (2)
  • app/client/src/Heartbeat.tsx (0 hunks)
  • app/client/src/index.tsx (0 hunks)
💤 Files with no reviewable changes (2)
  • app/client/src/Heartbeat.tsx
  • app/client/src/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Oct 11, 2024
@ApekshaBhosale ApekshaBhosale added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Oct 11, 2024
@ApekshaBhosale ApekshaBhosale changed the title chore: removed code chore: heartbeat code removed Oct 15, 2024
@ApekshaBhosale ApekshaBhosale merged commit 3032adc into release Oct 15, 2024
224 of 232 checks passed
@ApekshaBhosale ApekshaBhosale deleted the remove-heartbeat-code branch October 15, 2024 08:01
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Oct 17, 2024
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11339670501>
> Commit: cc4ac6d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11339670501&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 15 Oct 2024 07:53:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Integrated New Relic for enhanced telemetry tracking.
  
- **Bug Fixes**
- Removed the `Heartbeat` component to streamline application
performance and rendering logic.

- **Chores**
	- Cleaned up unnecessary variables related to component rendering.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants