Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skipping test becasuea of an open Issue[RestAPIDatasrouce spec] #37354

Closed
wants to merge 2 commits into from
Closed

test: Skipping test becasuea of an open Issue[RestAPIDatasrouce spec] #37354

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6217fc9
test: updated the spec to check if the API is visible or not
Nov 13, 2024
a38a66c
commenting the test because of open bug
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/client/cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,24 @@ describe(
function () {
it("1. Create a rest datasource + Bug 14566", function () {
apiPage.CreateAndFillApi(testdata.baseUrl + testdata.methods);
cy.get(".t--store-as-datasource").click();
agHelper.WaitUntilEleAppear(apiPage._saveAsDS);
cy.get(apiPage._saveAsDS).click({ force: true });
Comment on lines +17 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid using force: true in click operations

Replace the force click with proper element state verification:

 agHelper.WaitUntilEleAppear(apiPage._saveAsDS);
-cy.get(apiPage._saveAsDS).click({ force: true });
+cy.get(apiPage._saveAsDS)
+  .should('be.visible')
+  .and('be.enabled')
+  .click();
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
agHelper.WaitUntilEleAppear(apiPage._saveAsDS);
cy.get(apiPage._saveAsDS).click({ force: true });
agHelper.WaitUntilEleAppear(apiPage._saveAsDS);
cy.get(apiPage._saveAsDS)
.should('be.visible')
.and('be.enabled')
.click();

//verifying there is no error toast, Bug 14566
agHelper.AssertElementAbsence(
locators._specificToast("Duplicate key error"),
); //verifying there is no error toast, Bug 14566
);
cy.testSelfSignedCertificateSettingsInREST(false);
cy.get("body").then((body) => {
if (
body.find('[value="http://host.docker.internal:5001"]').length < 1
) {
cy.get('[placeholder="https://example.com"]').type(
"http://host.docker.internal:5001",
);
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Multiple violations of Cypress best practices

  1. Avoid using attribute selectors
  2. Move hardcoded URLs to test data
  3. Use data-cy attributes for element selection
-cy.get("body").then((body) => {
-  if (body.find('[value="http://host.docker.internal:5001"]').length < 1) {
-    cy.get('[placeholder="https://example.com"]').type(
-      "http://host.docker.internal:5001",
-    );
-  }
-});
+const TEST_URL = testdata.restApiUrl;
+cy.get(apiPage._urlInputField)
+  .should('exist')
+  .then(($el) => {
+    if ($el.val() !== TEST_URL) {
+      cy.get(apiPage._urlInputField).type(TEST_URL);
+    }
+  });

Also, update the testdata.json to include:

{
  "restApiUrl": "http://host.docker.internal:5001"
}

cy.saveDatasource();
cy.contains(".datasource-highlight", "http://host.docker.internal:5001"); //failing here since Save as Datasource is broken
cy.contains(".datasource-highlight", "http://host.docker.internal:5001");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use data attributes and avoid hardcoded values

Replace class selector with data attribute and use the URL from test data.

-cy.contains(".datasource-highlight", "http://host.docker.internal:5001");
+cy.get(apiPage._datasourceURLHighlight)
+  .should('contain', testdata.restApiUrl);

Committable suggestion skipped: line range outside the PR's diff.

cy.SaveAndRunAPI();
});
},
Expand Down
Loading