fix: [Plugin Action Editor] Avoid multiple init of Form Eval

[hetunandu]

Description

Noticed that we are causing the evaluation of the form twice because changeQuery also initiates the eval. Since the changeQuery also handles other aspects, will defer to that and not initiate again for UQI Forms.

Fixes #37772

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12062575061
Commit: f531f84
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 28 Nov 2024 05:14:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Removed the useInitFormEvaluation hook from the UQIEditorForm, streamlining the form initialization process.
  • Updated the useChangeActionCall hook to directly access the action.id, enhancing reliability in action dispatching.

[coderabbitai]

Walkthrough

The changes in this pull request involve the removal of the useInitFormEvaluation hook from the UQIEditorForm component and the deletion of its corresponding file. Additionally, the useChangeActionCall hook has been modified to directly access the id property of the action object, eliminating the optional chaining operator. The overall structure and functionality of the components remain intact.

Changes

File	Change Summary
app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/UQIEditorForm.tsx	Removed the useInitFormEvaluation hook from the UQIEditorForm component.
app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/hooks/useInitFormEvaluation.ts	Deleted the useInitFormEvaluation hook file.
app/client/src/PluginActionEditor/components/PluginActionForm/hooks/useChangeActionCall.ts	Modified the useChangeActionCall hook to access action.id directly, removing optional chaining.

Assessment against linked issues

Objective	Addressed	Explanation
Mongo plugin action form is not rendering properly (#37772)	❌	The changes do not address rendering issues.

Possibly related PRs

• chore: Calling changeApi and changeQuery actions based on PluginType when plugin action form component is mounted #36398: Involves changes to the useChangeActionCall hook, related to the modifications in this PR.
• chore: [Plugin Action Form] Common Editor State #36512: Also modifies the useChangeActionCall hook, relevant to the main PR's changes.
• chore: Moving action settings from editor form to toolbar  #36894: Includes changes to the PluginActionForm component, directly related to the main PR.
• chore: Removing usage of action right pane component #37020: Involves the CommonEditorForm component, relevant to the updates in the UQIEditorForm.
• chore: [Plugin Action Editor] Query Form evaluation #37224: Focuses on enhancing initialization processes, related to the main PR's changes.
• chore: [Plugin Action Editor] Defer plugin config checks #37655: Modifications to the PluginActionContextType interface, relevant to the main PR.
• fix: Plugin Action Editor navigation issue with git #37670: Addresses a navigation issue related to action IDs, relevant to the main PR's changes.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• ankitakinger
• albinAppsmith

🌟 In the land of code where hooks reside,
A form once evaluated, now takes a slide.
With changes made, the structure stays bright,
Removing the old, embracing the light!
Let's celebrate the code, both clean and neat,
For every little change makes our journey sweet! 🎉

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 62724e9 and f531f84.

📒 Files selected for processing (3)

• app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/UQIEditorForm.tsx (0 hunks)
• app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/hooks/useInitFormEvaluation.ts (0 hunks)
• app/client/src/PluginActionEditor/components/PluginActionForm/hooks/useChangeActionCall.ts (1 hunks)

💤 Files with no reviewable changes (2)

• app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/UQIEditorForm.tsx
• app/client/src/PluginActionEditor/components/PluginActionForm/components/UQIEditor/hooks/useInitFormEvaluation.ts

🔇 Additional comments (2)

app/client/src/PluginActionEditor/components/PluginActionForm/hooks/useChangeActionCall.ts (2)

18-18: LGTM! Safely removed optional chaining

The removal of optional chaining is safe here as action is guaranteed to exist from the context.

---

Line range hint 21-31: Verify the form evaluation behavior

Based on the PR objectives, changeQuery was causing double evaluation of forms. While this change addresses the symptom by removing useInitFormEvaluation, we should verify that this doesn't affect other plugin types that might rely on the form evaluation.

Let's verify the impact:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.