fix : fix vulnerability CVE-2024-38356

[yatinappsmith]

Description

fix vulnerability CVE-2024-38356

Fixes # https://github.com/appsmithorg/appsmith/security/dependabot/348

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12270529428
Commit: 826da68
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Wed, 11 Dec 2024 06:36:30 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Updated the tinymce dependency version from 6.8.3 to 6.8.4.
• New Features
  • Added new badges in the README for Discord, GitHub activity, Docker pulls, and YouTube channel statistics to enhance community engagement.

[coderabbitai]

Walkthrough

The pull request involves an update to the package.json file for the appsmith project, specifically changing the version of the tinymce dependency from 6.8.3 to 6.8.4. Additionally, the README.md file has been modified to include new badges linking to community resources, enhancing its visual appeal. No other sections of either file were altered, maintaining the overall structure and content of both documents.

Changes

File	Change Summary
app/client/package.json	Updated tinymce dependency version from 6.8.3 to 6.8.4.
README.md	Added new badges for Discord, GitHub releases, Docker, and YouTube.

Possibly related PRs

• chore:update README.md to reflect Youtube stats #36874: This PR updates the README.md file to add new YouTube badges, which is directly related to the changes made in the main PR that also involves modifications to the README.md file, albeit for different content.
• fix: Plugin Action Editor navigation issue with git #37670: This PR modifies the useChangeActionCall hook, which is part of the client-side codebase. While it does not directly relate to the package.json changes, it is part of the same project and could be indirectly relevant in terms of overall functionality and dependencies.
• fix: Leaving editable tab in error state #37981: This PR addresses the handling of error states in editable tabs, which is part of the client-side application. Similar to the previous PR, it does not directly relate to the package.json changes but is part of the same project context.

Suggested labels

Bug, Documentation, skip-changelog

Suggested reviewers

• sharat87
• ApekshaBhosale
• NandanAnantharamu

In the code, a change so slight,
A version bump, oh what a sight!
TinyMCE now shines anew,
With 6.8.4, it's ready to view!
A simple tweak, but oh so grand,
In the world of code, we take a stand! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[KelvinOm]

@yatinappsmith @hetunandu I think we should run all the tests. Previously, we had issues with locators when updating tinymce package. We need to make sure that this doesn't happen now.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

README.md (1)

Line range hint 9-24: LGTM! Well-structured badge implementation.

The badges are properly aligned, use consistent styling, and provide valuable community metrics. The UTM parameters in the links will help track traffic sources effectively.

Consider adding alt text to the badge images that describes the metric being shown, for better accessibility. For example:

-<img alt="Discord" src="https://img.shields.io/discord/725602949748752515?color=5865F2&label=Discord&style=for-the-badge" />
+<img alt="Discord Member Count" src="https://img.shields.io/discord/725602949748752515?color=5865F2&label=Discord&style=for-the-badge" />

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2a1ed0c and 826da68.

📒 Files selected for processing (1)

• README.md (1 hunks)

🔇 Additional comments (1)

README.md (1)

7-8: LGTM! Good use of spacing.

The empty lines provide clear visual separation between the logo and the badges section.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions]

This PR has been closed because of inactivity.