chore: Remove unused welcome email option

[sharat87]

This is unused and very old functionality that we don't need anymore.

Automation

/test sanity

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Enhanced observability features with new configurations for metrics and tracing.
• Bug Fixes
  • Removed the welcome email feature toggle, simplifying email configuration.
• Chores
  • Updated application properties to reflect changes in email handling and observability settings.

[coderabbitai]

Walkthrough

The changes involve the removal of the isWelcomeEmailEnabled boolean field from the EmailConfig class and the corresponding property from the application.properties file. This simplifies the email configuration by eliminating the welcome email feature toggle. Additionally, new properties related to observability and tracing have been introduced or modified, enhancing the configuration management of the application.

Changes

File	Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/EmailConfig.java	Removed the isWelcomeEmailEnabled boolean field.
app/server/appsmith-server/src/main/resources/application.properties	Removed the property emails.welcome.enabled. Added/modified properties for observability and tracing.

Possibly related PRs

• chore: Removed manipulation for custom traceparent header #37121: Involves the removal of the MicrometerTraceHeaderWebFilter class, simplifying configuration management.
• chore: Switch server tracing configs to use OTEL #37333: Updates server tracing configurations to utilize OpenTelemetry, aligning with changes in configuration settings.
• chore: Remove unused JSON superuser signup route #37378: Removes the unused JSON superuser signup route, part of a broader effort to streamline the codebase.
• chore: Read mail env variables only when needed #37660: Modifies the scope of environment variables in the mailer module, relating to the simplification of email configurations.
• fix: Signup from OAuth not being detected correctly #37697: Addresses issues with OAuth signup detection, indirectly relating to email configuration changes.
• chore: skipping file change #37774: Modifies the client build workflow, reflecting ongoing adjustments in the codebase.
• chore: remove the if condition as not supported in workflow file #38015: Removes unsupported conditions in a workflow file, aligning with the theme of simplifying the codebase.

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

• nidhi-nair
• ashit-rath
• pratapaprasanna

🎉 In the code's dance, a toggle's gone,
Welcome emails fade, but the show goes on!
With observability now in sight,
Tracing the paths, oh what a delight!
Simplified configs, a cleaner space,
In the realm of code, we embrace the grace! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 493dba0 and 1d4dfa2.

📒 Files selected for processing (2)

• app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/EmailConfig.java (0 hunks)
• app/server/appsmith-server/src/main/resources/application.properties (0 hunks)

💤 Files with no reviewable changes (2)

• app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/EmailConfig.java
• app/server/appsmith-server/src/main/resources/application.properties

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.git.ServerSchemaMigrationEnforcerTest#saveGitRepo_ImportAndThenExport_diffOccurs