Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: commenting dependent test which was missed in RestApiOAuth2Validation_spec #38239

Merged
merged 3 commits into from
Dec 19, 2024
Merged

test: commenting dependent test which was missed in RestApiOAuth2Validation_spec #38239

merged 3 commits into from
Dec 19, 2024
+2 −2

Conversation

NandanAnantharamu
Copy link
Collaborator

@NandanAnantharamu NandanAnantharamu commented Dec 18, 2024 •
edited by github-actions bot
Loading

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12405587425
Commit: baf2d3b
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Thu, 19 Dec 2024 04:03:20 UTC

Summary by CodeRabbit

  • Tests
    • Disabled the execution of the OAuth2 validation test suite.
    • Skipped a specific test case within the suite.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2024 •
edited
Loading

Walkthrough

The pull request involves modifications to the RestApiOAuth2Validation_spec.ts Cypress test file, specifically disabling the entire test suite by changing describe to describe.skip and skipping one specific test case by converting it to it.skip. This change effectively prevents the OAuth2 client credentials tests from running while preserving their original implementation.

Changes

File Change Summary
app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts Disabled test suite and one test case by using describe.skip and it.skip

Suggested labels

ok-to-test

Suggested reviewers

  • ApekshaBhosale
  • sagar-qa007

Possibly related PRs

Poem

🕵️ Test suite sleeping, quietly waiting
Cypress tests now hibernating
describe.skip waves its magic wand
Silencing checks with a gentle bond
Code rests, no assertions in sight 🌙

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e37d09 and baf2d3b.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Dec 18, 2024
@NandanAnantharamu NandanAnantharamu added the ok-to-test Required label for CI label Dec 19, 2024
@sagar-qa007 sagar-qa007 merged commit 80f4739 into release Dec 19, 2024
49 checks passed
@sagar-qa007 sagar-qa007 deleted the test/commentingTestRestAPI branch December 19, 2024 05:04
NandanAnantharamu added a commit that referenced this pull request Dec 27, 2024
@NandanAnantharamu
test: commenting dependent test which was missed in RestApiOAuth2Vali…
83f8620 
…dation_spec (#38239)

/ok-to-test tags="@tag.Sanity"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12405587425>
> Commit: baf2d3b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12405587425&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Dec 2024 04:03:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
	- Disabled the execution of the OAuth2 validation test suite.
	- Skipped a specific test case within the suite.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
@coderabbitai coderabbitai bot mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagar-qa007 sagar-qa007 sagar-qa007 approved these changes

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale ApekshaBhosale is a code owner

Assignees
No one assigned
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NandanAnantharamu @sagar-qa007