-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Masking user data in mixpanel session recordings #38267
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ef53807
chore: Masking for response tables
hetunandu bb1d394
Merge branch 'release' into chore/mixpanel-add-masking-classes
hetunandu 9a4b074
chore: Peek overlay, other response types and logs
hetunandu 0caca19
chore: Widgets masking
hetunandu 71dc05a
chore: Add feature flagging support
hetunandu f0c0d05
Merge branch 'release' into chore/mixpanel-add-masking-classes
hetunandu 15f654e
chore: Update selector
hetunandu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -311,7 +311,7 @@ export function LogItem(props: LogItemProps) { | |
})} | ||
{props.state && ( | ||
<JsonWrapper | ||
className="t--debugger-log-state" | ||
className="t--debugger-log-state mp-mask" | ||
onClick={(e) => e.stopPropagation()} | ||
> | ||
<ReactJson src={props.state} {...reactJsonProps} /> | ||
|
@@ -325,7 +325,7 @@ export function LogItem(props: LogItemProps) { | |
if (typeof logDatum === "object") { | ||
return ( | ||
<JsonWrapper | ||
className="t--debugger-console-log-data" | ||
className="t--debugger-console-log-data mp-mask" | ||
key={Math.random()} | ||
onClick={(e) => e.stopPropagation()} | ||
> | ||
|
@@ -334,7 +334,7 @@ export function LogItem(props: LogItemProps) { | |
); | ||
} else { | ||
return ( | ||
<span className="debugger-label" key={Math.random()}> | ||
<span className="debugger-label mp-mask" key={Math.random()}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hope you realize that this random key is your doing now :) |
||
{`${logDatum} `} | ||
</span> | ||
); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Additional sensitive data displays found in ErrorLogs that need masking
The
LogCollapseData.tsx
component also usesReactJson
to display state data but lacks themp-mask
class. Consider applying consistent masking across all debugger data displays.app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogCollapseData.tsx
: Addmp-mask
class to theJsonWrapper
component displaying state data🔗 Analysis chain
LGTM! Comprehensive masking implementation
The mp-mask class is consistently applied across all data display elements, covering both JSON and text content.
Also applies to: 328-328, 337-337
Let me verify if the masking is consistently implemented across other debugger components.
Let me check if there are any other sensitive data displays in the debugger components that might need masking.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 1124
Script:
Length of output: 2771
Script:
Length of output: 3035