test: exluding from airgap list of tests #38596
Conversation
NandanAnantharamu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe pull request modifies a Cypress end-to-end test specification for import functionality, specifically adding a tag Changes
Suggested Labels
Suggested Reviewers
Possibly Related PRs
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/VerifyImport_spec.ts (2)
23-45: Move datasource names to constants.The datasource array should be defined as a constant outside the test case, preferably in a separate constants file.
64-66: Optimize assertions in forEach loop.Instead of asserting each datasource individually, consider using a single assertion to check all datasources are present. This will improve test performance.
Example:
cy.get(locators._listItemTitle).should(($elements) => { const texts = $elements.map((_, el) => Cypress.$(el).text()).get(); expect(texts).to.include.members(Datasource); });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/VerifyImport_spec.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/VerifyImport_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/VerifyImport_spec.ts (2)
14-17: LGTM! Tag addition for airgap exclusion is properly implemented.
18-20: LGTM! Before hook setup is appropriate.
| agHelper.GetNClick(appSettings.locators._importHeader); | ||
| agHelper.AssertElementEnabledDisabled(appSettings.locators._importBtn); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Combine assertions and use data- attributes.*
Consider the following improvements:
- Use data-* attributes for selectors instead of class-based locators
- Combine the import button assertions into a single expect statement
Example:
cy.get('[data-cy=import-button]')
.should('exist')
.and('be.visible')
.and('be.enabled');Also applies to: 53-58
Summary by CodeRabbit