fix: copy changes to the description and content of modal #38637
Conversation
WalkthroughThe pull request focuses on updating user interface messages and text content across multiple files related to integration request and premium datasource modals. The changes primarily involve refining text descriptions, labels, and placeholders to improve clarity and provide more context-specific messaging. The modifications span constants, helper functions, and component files, aiming to enhance the user experience when requesting or exploring new integrations. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
Integrations Pod General
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12754754867. |
|
Deploy-Preview-URL: https://ce-38637.dp.appsmith.com |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12768050423. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (1)
77-77: Simplify the template literal construction.The nested template literal and empty string fallback can be simplified.
- return `${integrationName} ${isBusinessOrEnterprise ? `${createMessage(PREMIUM_DATASOURCES.COMING_SOON_SUFFIX)}` : ""}`; + return `${integrationName}${isBusinessOrEnterprise ? ` ${createMessage(PREMIUM_DATASOURCES.COMING_SOON_SUFFIX)}` : ''}`;
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/src/ce/constants/messages.ts(2 hunks)app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- app/client/src/ce/constants/messages.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-build / client-build
🔇 Additional comments (3)
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (3)
82-82: LGTM! Parameter ordering follows best practices.The new parameter placement maintains a clean separation between required and optional parameters.
90-97: LGTM! Clean implementation of message customization.The message creation logic is well-structured and consistently handles the integration name for both email scenarios.
77-97: Verify callers are updated with the new parameter.Since both
getContactFormModalTitleandgetContactFormModalDescriptionhave updated signatures requiringintegrationName, we should verify all callers are updated.✅ Verification successful
All callers are properly updated with the new parameters
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for calls to these functions to ensure they include the integrationName parameter echo "Searching for function calls..." rg "getContactFormModalTitle\(" --type ts rg "getContactFormModalDescription\(" --type ts # Verify message constants are updated to handle the new parameter echo "Checking message constants..." rg "PREMIUM_DATASOURCES\.(?:RELEVANT_EMAIL_DESCRIPTION|NON_RELEVANT_EMAIL_DESCRIPTION)" --type tsLength of output: 891
Script:
#!/bin/bash # Get the complete context of the function call rg "getContactFormModalDescription\(" -A 5 --type tsLength of output: 711
|
Deploy-Preview-URL: https://ce-38637.dp.appsmith.com |
Description
The request new integration and premium datasources modal content and ui spacing is fixed in the PR.
Fixes #38599
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12768028542
Commit: 672de69
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Tue, 14 Jan 2025 13:40:24 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
UI/UX Improvements
Bug Fixes