feat: update autocomplete sorting #38690

devin-ai-integration · 2025-01-16T08:02:47Z

What does this PR do?

Updates the dataTypeSortRules.ts configuration file to add more entries into the data types arrays for improved autocomplete suggestions.

Changes

Added new entries to the following data type arrays:

STRING: Added "selectedOptionValue", "value"
NUMBER: Added "pageOffset", "pageSize"
OBJECT: Added "formData"
ARRAY: Added "selectedOptionValues", "selectedValues"
BOOLEAN: Added "isValid", "isChecked", "isSwitchedOn"

Updates the scoring of certain rules in AutocompleteSortRules.ts to get better results in best match

Changes

DataTreeEntityNameRule: Reduce score instead of increasing it. Reduce rule weight
TypeMatchRule: Do not consider types of completions that are of "EntityName".
RecentEntityRule: Do not increase scores of the same entity based on recency

fixes #38721

Link to Devin run: https://app.devin.ai/sessions/2e8beba69a26426cbfcb277fa260afe6

/ok-to-test tags="@tag.All"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12824699796
Commit: 2132483
Cypress dashboard.
Tags: @tag.All
Spec:

Fri, 17 Jan 2025 10:18:37 UTC

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

devin-ai-integration · 2025-01-16T08:02:50Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

⚙️ Control Options:

Disable automatic comment and CI monitoring

coderabbitai · 2025-01-16T08:02:57Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kocharrahul7 · 2025-01-16T08:24:19Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-16T08:24:39Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12804851139.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38690.
recreate: .

github-actions · 2025-01-16T08:37:47Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

kocharrahul7 · 2025-01-16T09:43:36Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-16T09:43:57Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12806167413.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38690.
recreate: .

devin-ai-integration · 2025-01-16T09:47:18Z

Note: Used --no-verify flag for this commit as this is a draft PR. Will address any lint/formatting issues during review.

github-actions · 2025-01-16T09:58:01Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

kocharrahul7 · 2025-01-16T11:15:10Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-16T11:15:29Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12807710201.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38690.
recreate: .

github-actions · 2025-01-16T11:29:20Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

…taTypeSortRules Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

kocharrahul7 · 2025-01-16T12:24:01Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-16T12:24:26Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12808805799.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38690.
recreate: .

github-actions · 2025-01-16T12:37:44Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

devin-ai-integration · 2025-01-16T14:01:17Z

/build-deploy-preview skip-tests=true

hetunandu · 2025-01-16T14:35:01Z

/build-deploy-preview

github-actions · 2025-01-16T14:35:22Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12811127962.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 38690.
recreate: .

github-actions · 2025-01-16T14:49:51Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

hetunandu · 2025-01-16T15:26:11Z

/build-deploy-preview

github-actions · 2025-01-16T15:26:33Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12812115361.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 38690.
recreate: .

…types

hetunandu · 2025-01-17T07:37:21Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-17T07:37:44Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12824717245.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38690.
recreate: .

github-actions · 2025-01-17T07:51:11Z

Deploy-Preview-URL: https://ce-38690.dp.appsmith.com

app/client/cypress/e2e/Regression/ClientSide/Autocomplete/Autocomplete_setters_spec.ts

feat: update dataTypeSortRules with new autocomplete entries

511c96f

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

github-actions bot added the Enhancement New feature or request label Jan 16, 2025

devin-ai-integration bot force-pushed the devin/1737014532-update-autocomplete-datatypes branch from 4c79250 to 511c96f Compare January 16, 2025 10:52

feat: add pageSize and pageOffset to UNKNOWN array in dataTypeSortRules

5279bf5

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

devin-ai-integration bot and others added 2 commits January 16, 2025 12:04

feat: add selectedOptionValue, text, and value to UNKNOWN array in da…

12799ed

…taTypeSortRules Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

chore: fix prettier formatting in dataTypeSortRules.ts

795822e

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

devin-ai-integration bot and others added 2 commits January 16, 2025 13:51

feat: update autocomplete scoring rules to reduce entity name priority

6fbd1fe

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

chore: fix prettier formatting

e02557d

Co-Authored-By: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>

Update AutocompleteSortRules.ts

97b56b7

github-actions bot added IDE Product Issues related to the IDE Product Javascript Product Issues related to users writing javascript in appsmith Query & JS Pod Issues related to the query & JS Pod Task A simple Todo labels Jan 17, 2025

fix: Test case

21d27a3

hetunandu added the ok-to-test Required label for CI label Jan 17, 2025

chore: Minor changes

ffe341f

hetunandu requested a review from sneha122 January 17, 2025 05:10

hetunandu marked this pull request as ready for review January 17, 2025 05:14

hetunandu changed the title ~~feat: update autocomplete dataTypeSortRules with new entries~~ feat: update autocomplete sorting Jan 17, 2025

sneha122 previously approved these changes Jan 17, 2025

View reviewed changes

fix: another text

1b7ce7f

hetunandu dismissed sneha122’s stale review via 1b7ce7f January 17, 2025 05:57

hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jan 17, 2025

hetunandu added 3 commits January 17, 2025 12:05

fix: Update cypress test cases

3e5bab1

Merge branch 'release' into devin/1737014532-update-autocomplete-data…

ec20d1f

…types

feat: Flatten Appsmith obj for better visibility in autocomplete

2132483

hetunandu requested review from ApekshaBhosale and sagar-qa007 as code owners January 17, 2025 07:36

hetunandu requested a review from sneha122 January 17, 2025 10:28

hetunandu enabled auto-merge (squash) January 17, 2025 10:36

sneha122 reviewed Jan 17, 2025

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Autocomplete/Autocomplete_setters_spec.ts Show resolved Hide resolved

hetunandu requested a review from sneha122 January 17, 2025 10:51

sneha122 approved these changes Jan 17, 2025

View reviewed changes

hetunandu merged commit 24a7fa5 into release Jan 17, 2025
83 checks passed

hetunandu deleted the devin/1737014532-update-autocomplete-datatypes branch January 17, 2025 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update autocomplete sorting #38690

feat: update autocomplete sorting #38690

devin-ai-integration bot commented Jan 16, 2025 •

edited by github-actions bot

Loading

devin-ai-integration bot commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

devin-ai-integration bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

devin-ai-integration bot commented Jan 16, 2025

hetunandu commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

hetunandu commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

hetunandu commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

feat: update autocomplete sorting #38690

feat: update autocomplete sorting #38690

Conversation

devin-ai-integration bot commented Jan 16, 2025 • edited by github-actions bot Loading

What does this PR do?

Changes

Changes

devin-ai-integration bot commented Jan 16, 2025

🤖 Devin AI Engineer

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

devin-ai-integration bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

kocharrahul7 commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

devin-ai-integration bot commented Jan 16, 2025

hetunandu commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

hetunandu commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

hetunandu commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

devin-ai-integration bot commented Jan 16, 2025 •

edited by github-actions bot

Loading