Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATAppConfigurationUpdateTask needs to retain self before updating task state #91

Closed
wooster opened this issue Apr 14, 2014 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@wooster
Copy link
Contributor

wooster commented Apr 14, 2014

This method:

- (void)configurationUpdaterDidFinish:(BOOL)success {
    @synchronized(self) {
        if (configurationUpdater) {
            if (!success) {
                self.failed = YES;
                [self stop];
            } else {
                self.finished = YES;
            }
        }
    }
}

Is unsafe because self.failed may cause the task to be deallocated. This entire statement should be wrapped in a retain/release pair, as with the other tasks.

@wooster wooster self-assigned this Apr 14, 2014
@wooster wooster added the Crash label Apr 14, 2014
wooster added a commit that referenced this issue Apr 14, 2014
@wooster wooster added this to the 0.5.0 milestone Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant