Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: web i18n #315

Merged
merged 7 commits into from
Jul 22, 2020
Merged

fix: web i18n #315

merged 7 commits into from
Jul 22, 2020

Conversation

alvinhui
Copy link
Contributor

@alvinhui alvinhui commented Jul 22, 2020 •
edited
Loading

  1. 功能完备性：支持 @alifd/next 的国际化：https://github.com/alibaba-fusion/next/blob/master/site/en-us/i18n.md
  2. 程序正确性：loading 的初始化值为 true，确保获取语言包后再开始渲染
  3. 程序容错性：需要有默认语言，确保语言不支持时使用默认的语言
  4. 代码一致性：createIntl 方法的封装使用

@alvinhui alvinhui self-assigned this Jul 22, 2020
@sspku-yqLiu sspku-yqLiu merged commit a4e666b into i18n/iceworks-component-builder Jul 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/i18n-for-component-builder branch July 22, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspku-yqLiu sspku-yqLiu Awaiting requested review from sspku-yqLiu

Assignees

@alvinhui alvinhui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinhui @sspku-yqLiu