Feat: support hide treeview and entry #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhc228
changed the title
luhc228
changed the title
|
判断天马模块进行单独抽一个方法，示例 |
|
天马模块更新 getProjectType 不太合适。它其实也 Rax 项目。 |
alvinhui
reviewed
Aug 28, 2020
alvinhui
reviewed
Aug 28, 2020
| detail: i18n.format('extension.iceworksApp.showEntriesQuickPick.generateComponent.detail'), | ||
| command: 'iceworks-ui-builder.generate-component', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
我觉得比较好的实现方式可能是：
[
{
label: i18n.format('extension.iceworksApp.showEntriesQuickPick.generateComponent.label'),
detail: i18n.format('extension.iceworksApp.showEntriesQuickPick.generateComponent.detail'),
command: 'iceworks-ui-builder.generate-component',
supportProjectTypes: ['react', 'rax'],
supportProjectFrameworks: ['icejs'],
},
]
这样？
当下可以先简单做。
alvinhui
approved these changes
Aug 28, 2020
delete-merged-branch
bot
deleted the
feat/support-hide-treeview-and-entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #468
目前策略：